Repository navigation
feat(ui): add row menu with create-from-existing for agents, templates, harnesses - #3661
Open
toreysoloio wants to merge 7 commits into
Open
toreysoloio wants to merge 7 commits into
toreysoloio wants to merge 7 commits into
Conversation
…sting Agents, agent templates and harnesses lists now offer edit, delete and "create new from this" in one row menu. The create item opens the existing new form prefilled from ?from=namespace/name; a source that cannot be loaded falls back to a blank form with an alert. Row clicks now ignore anything outside the row's own markup, so portalled modals and dropdowns no longer activate the row. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Torey Scheer <87029548+toreysoloio@users.noreply.github.com>
Contributor
Author
|
Before/after on a real kagent cluster (base build vs this PR, same data). Reel and screenshots below.
No database or query code changed, so no benchmark. reel.mp4ScreenshotsBefore: agents list row actions
Before: templates list row actions
Before: harnesses list row actions
Before: new agent from ?from=kagent/assistant
Before: new template from ?from=kagent/support-triage
Before: new harness from ?from=kagent/kagent-default
Before: new harness from a missing source
Before: delete confirmation on a template row
After: agents list row actions
After: templates list row actions
After: harnesses list row actions
After: new agent from ?from=kagent/assistant
After: new template from ?from=kagent/support-triage
After: new harness from ?from=kagent/kagent-default
After: new harness from a missing source
After: delete confirmation on a template row
🤖 written by Claude |
- Keep the copy form mounted when a failed copy source loads late, and say in the alert that it loaded but was not applied so edits are kept. Shared CopyNotice and useMountedBlank across the agent, template and harness forms. - Show the harness "not found" alert for a missing copy source. - copyName stays within 63 characters and never ends in a non-alphanumeric. - Show the disabled-delete reason inline; restore the row-click popover and dropdown guards. - Extract DeleteConfirmModal shared by the menu and DeleteResourceButton, mounted only while open; keep Popconfirm open until the delete settles. - Shrink the single-icon actions column. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Torey Scheer <87029548+toreysoloio@users.noreply.github.com>
- Move copyName, useMountedBlank, copyPath and copySource out of the row menu into table/copyFrom.ts. - useMountedBlank no longer reports blank once the copy source is dropped, so a plain new form never shows the late-load warning. - Fold the harness "not found" alert into CopyNotice. - Remove the unused disabled-delete props from RowActionsMenu. - Hoist the agent/copy base in AgentFormPage; add a force-reset regression test for the delete modal. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Torey Scheer <87029548+toreysoloio@users.noreply.github.com>
toreysoloio
marked this pull request as ready for review
November 12, 2026 20:04
The modal was unmounted the instant it closed, so antd never ran its exit animation. Keep it mounted until afterClose, which still resets its state for the next open. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Torey Scheer <87029548+toreysoloio@users.noreply.github.com>
Also name the agent form's copy-source gating once instead of twice. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Torey Scheer <87029548+toreysoloio@users.noreply.github.com>
…onsMenu Signed-off-by: Torey Scheer <87029548+toreysoloio@users.noreply.github.com> # Conflicts: # ui/src/pages/AgentTemplatesPage.tsx
… row menus Row menus take a rowActions contribution as data, so the host draws each as a real menu item with keyboard navigation, per-row visibility and contained failures. Validated at boot, including across extensions, and documented. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Torey Scheer <87029548+toreysoloio@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 written by Claude (start)
Closes #3615
Testing
⋯menu on a row in each tab (Agents, Agent templates, Harnesses): it offers Edit (Open on templates), Create new … from this, and Delete, which still asks before deleting.-copyname; save it and confirm the copy appears in the list./harnesses/new?from=kagent/nope(likewise/agents/newand/agent-templates/new): you get a blank form with an alert saying the source could not be loaded.Release note
🤖 written by Claude (end)