Repository navigation
Conversation
A send to a Session whose runtime is lost was told only to start another conversation. Name the manual recovery call in the message, so a client that only sends knows RevertSession exists. For a lost runtime, RevertSession answers FAILED_PRECONDITION with the loss. The error's code and reason are unchanged. The lost-runtime gateway test asserts the hint. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Ada Lundhe <adalundhe@lundhe.audio>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3399, stacked on its branch. It addresses @EItanya's nit on
ErrRuntimeUnrecoverable.A send to a Session whose runtime is lost (its recorded Actor is missing or was replaced) was told only to start another conversation. The refusal now also names the manual recovery call:
The error's gRPC code and ErrorInfo reason are unchanged, so clients that branch on them behave the same. For a runtime that is truly lost,
RevertSessionanswersFAILED_PRECONDITIONand confirms the loss rather than restoring it.Testing: the lost-runtime gateway test asserts the hint; the Session and gateway tests pass; lint reports 0 issues.
🤖 Generated with Claude Code