Repository navigation
Conversation
Support custom deployment metadata annotations and configurable PodDisruptionBudget for kagent-tools. Assisted-by: Gemini 3.7 Flash Signed-off-by: Anthony Hausman <anthonyhaussmann@gmail.com>
…vailable Use hasKey so minAvailable/maxUnavailable of 0 are rendered, fail when both or neither are set, and add unit tests for these cases. Signed-off-by: Dmytro Rashko <dimetron@me.com>
- Add kagent-tools.pdb.isSet/validate helpers: null and "" are unset, 0 and percentages are kept; both-set and neither-set fail with actionable messages (mirrors kagent's controller PDB). - Default to maxUnavailable: 1 when enabled. - Only render the PDB when replicaCount > 1 (istio pattern), still validating config, and warn in NOTES when it is skipped. - Expand unit tests. Signed-off-by: Dmytro Rashko <dimetron@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #73 (includes its commit, rebased on
main) and combines the best PDB patterns from kagent's own chart and istio.Design
kagent-tools.pdb.isSet:nulland""are unset;0and percentages are keptkagent-tools.pdb.validatefails with an actionable messagemaxUnavailable: 1when enabled (minAvailable: null)kagent-tools.selectorLabels(cannot drift from the Deployment)unhealthyPodEvictionPolicywithreplicaCount > 1; a single-replica PDB protects nothing or blocks drainsNOTES.txtwarns when the PDB is skippedPrior art (CNCF charts)
0maxUnavailablewinsmaxUnavailablewinsminAvailable: 0minAvailable: 1maxUnavailablewinsminAvailable: 1Testing
make helm-test— 36/36 passing;helm lintclean.Relates to #73