Repository navigation
Conversation
The chart passed otel.tracing.enabled as OTEL_TRACING_ENABLED, which the server never reads; it reads OTEL_SDK_DISABLED. With the default values tracing stayed on and the gRPC exporter kept dialing host.docker.internal:4317, logging export timeouts. Set OTEL_SDK_DISABLED from the value and only pass the exporter settings when tracing is on. Also drop the env vars nothing reads: OTEL_EXPORTER_OTLP_TRACES_TIMEOUT (the exporter timeout is fixed in code), PROMETHEUS_USERNAME, PROMETHEUS_PASSWORD, GRAFANA_URL, GRAFANA_API_KEY and KAGENT_NAMESPACE, with their values and README entries. Fixes kagent-dev#92 Signed-off-by: Lucas Barros <lucasbarros.kam@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #92.
otel.tracing.enabledwas rendered asOTEL_TRACING_ENABLED, which nothing reads. The server only switches tracing off onOTEL_SDK_DISABLED(internal/telemetry/config.go), so on a default install (enabled: false, endpointhttp://host.docker.internal:4317)SetupOTelSDKstill built a gRPC exporter for that host. Inside a cluster it does not resolve, and the pod logstraces export: ... name resolver errortimeouts, the same lines as in #27. Just dropping the endpoint would not help either: with no endpoint the server falls back to the pretty-printed stdout exporter.Changes in the chart:
OTEL_SDK_DISABLEDis nownot otel.tracing.enabled.OTEL_EXPORTER_OTLP_ENDPOINTandOTEL_EXPORTER_OTLP_TRACES_INSECUREare only set when tracing is on.OTEL_EXPORTER_OTLP_TRACES_TIMEOUT/otel.tracing.exporter.otlp.timeout(both exporters are built withWithTimeout(30s), which wins over the env var),PROMETHEUS_USERNAME/PROMETHEUS_PASSWORD(no Prometheus tool sends auth, and the password was a plain value),GRAFANA_URL/GRAFANA_API_KEY(no Grafana provider),KAGENT_NAMESPACE.GRAFANA_URL/GRAFANA_API_KEYas supported settings.Wiring Prometheus basic auth from a Secret would be a feature of its own, so I went with the "remove" option for those.
tools.loglevelis left as is for the reason given in #100.Tests: three new cases in
helm/kagent-tools/tests/deployment_test.yaml(SDK disabled by default with no exporter endpoint, SDK enabled with the configured endpoint, none of the dropped vars rendered). Onmainall three fail; with this changemake helm-testpasses 26/26.AI disclosure: written with the help of Claude Code, reviewed and tested by me.