Skip to content

feat(helm): add extraVolumes/extraVolumeMounts to the tools deployment - #74

Open
braghettos wants to merge 1 commit into
kagent-dev:mainfrom
braghettos:feat/extra-volumes
Open

braghettos wants to merge 1 commit into
kagent-dev:mainfrom
braghettos:feat/extra-volumes

Conversation

@braghettos

Copy link
Copy Markdown
Contributor

Adds extraVolumes and extraVolumeMounts to the kagent-tools deployment, appended to the existing tmp volume. Both default to [], so there's no change when unset.

Why

There's currently no way to mount an additional volume on the tools container via values. A concrete use case: mounting a kubeconfig so kubectl targets an authenticating proxy that scopes tool calls to the calling user's RBAC (rather than the tools ServiceAccount) — but this is generically useful for extra CA bundles, config, etc.

Change

# values.yaml
extraVolumes: []
extraVolumeMounts: []

Rendered into the deployment via {{- with .Values.extraVolumes }} / {{- with .Values.extraVolumeMounts }}.

helm template verified with a sample configMap volume; no diff when the values are empty.

@dimetron

Copy link
Copy Markdown
Collaborator

Thanks for the contribution! Please fix the DCO check (sign off the commit with git commit --amend -s) and rebase onto main to resolve the merge conflicts.

Allows mounting additional volumes on the kagent-tools container via values —
e.g. a kubeconfig to point kubectl at an authenticating proxy (per-user RBAC),
extra CA bundles, etc. Standard Kubernetes volume / volumeMount objects, appended
to the existing tmp volume. No behaviour change when unset (default []).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Diego Braga <diego.braga86@gmail.com>
@braghettos

Copy link
Copy Markdown
Contributor Author

Thanks! Rebased onto main (one conflict at the end of deployment.yaml, where the extra blocks follow the tmp volume) and signed off. I also added two cases to tests/deployment_test.yaml: with no values only tmp is mounted, and extraVolumes/extraVolumeMounts are appended after tmp. helm unittest helm/kagent-tools: 25/25.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants