Repository navigation
Conversation
masnwilliams
approved these changes
Oct 28, 2026
masnwilliams
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I checked the claims against kernel-mcp-server main and found no factual errors. The skill also passes the server's blocked-language and casing checks, and sync-plugin-skills.sh --check passes.
Non-blocking suggestions:
- Split by entitlement. Logins and payments are about 60% of the ~3.5k words, and most of that only applies when the vault tools are available. Moving them to
references/vault-logins.mdandreferences/payments.mdwould keep SKILL.md short. Both the skills build and the sync script already handle multi-file skills. - Parameter-level details repeated from tool descriptions. The payments and vault sections restate details that
manage_vault_cards/manage_vault_items/manage_vault_walletsalready carry: the 50000 minor-unit cap, 409 after authorize,page_not_found/ambiguous_page,billing_*, and the "can't be updated" rules. The server pins the skill by commit, so these copies can drift from the tool text. Keeping only the ordering and stop rules would avoid that. - Create-only list. Step 1 under browser sessions leaves out
network.allowed_hosts, which can't be added to a browser created without one.stealth,headless,remote_forward,chrome_policyandkiosk_modeare also create-only. Consider adding them or rewording to "includes". remote_forward. ssh traffic doesn't count as browser activity, so the timeout needs raising. The user also needs the KERNEL CLI andwebsocatlocally.search_docs. It dropped out of the routing table.
After merge: bump SKILLS_COMMIT in kernel-mcp-server to the merge commit on main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rewrites the
kernel-mcpskill around the multi-step flows that span several MCP tools. The old version mostly listed tools, which repeated what each tool's description and the server'sinstructionsalready tell the model. The new skill covers order of operations, decision points, and stop/never-retry rules, and refers to tools only by name and action.Stacked on #49. It edits only
skills/kernel-mcp/SKILL.md, regenerates the Grok copy withscripts/sync-plugin-skills.sh, and bumps the Grok plugin to 1.2.0.New structure
get_connection_context,project), which tools are gated (vault tools andweb_searchby entitlement,open_auth_loginby MCP Apps support), the rule that secrets and bearer links stay out of chat, and the 60-second default timeout.proxyobject, names vs ids, profiles, named Playwright executors, pools, and REPL state rules.lookup→resolve/get_analysis→ apply →submit_feedback.confirm_transaction, and a stop-rules table.Factual corrections
datacenteris not an accepted proxy type. Types areisp,residential,mobile, andcustom, with targeting inconfig.proxy_idonmanage_browsersis deprecated in favor ofproxy: {id|name|mode}.manage_auth_connections listfilters withdomain_filter, must be read across every page, and the user picks when several accounts match.NEEDS_AUTHconnection is reauthenticated (open_auth_loginmode: "reauth"orloginon its id), not recreated.waitlong-polls for at most 30 seconds and must be called again while pending.open_auth_loginis preferred when the client supports MCP Apps.manage_profiles setupsaves the profile only when the setup browser is deleted, and needsupdate_existingfor an existing name.releaseneedsid_or_nameandsession_id. Pooled browsers can't attach vaults. Lease idle timeout defaults to 600 seconds.manage_extensionsis list/get/delete only. Upload happens outside MCP, and extensions are create-only on a browser.manage_replaysalso haslistand returns view URLs. Framerates above 20 needgpu.get_telemetryreads deleted sessions only by id, and only for activity captured while telemetry was enabled. Telemetry is off by default and its default categories leave out console, network, and page events.browser_replignores expression values (output goes throughrepl.writeand friends), and a timeout drops all state.Each claim was checked against
kernel/kernel-mcp-servermain, includingvault-cards.ts,vault-wallets.ts,vault-items.ts,vault-credentials.ts, andvault-responses.tsfor the payment and vault sections. Rules the source leaves ambiguous were left out.Login guidance follows the docs
The login section opens with the decision from
auth/overview.mdx,auth/fill-from-vault.mdx, andauth/managed-auth.mdx, before either flow's steps:The vault steps mirror
vaults/overview.mdx,vaults/fill.mdx,vaults/credentials.mdx,vaults/1password.mdx, andbrowsers/use-vault-credentials-in-browser-agent.mdx:fillnever submits; retry only after checking the page, never in a loopThe payment steps follow
browsers/payments.mdx: verify the purchase first, and never retry a failed, timed-out, rejected, or indeterminate payment.Wording
The MCP server will serve this skill, and its tests hold skill prose to its access-language and brand-casing rules. Prose avoids the blocked terms and uses "site-compatibility" and "sites the user is authorized to access".
stealthappears only as an API field in code. Prose is lowercase except KERNEL.Testing
scripts/sync-plugin-skills.sh --checkpasses.kernel/kernel-mcp-server.bun test src/lib/mcp/prompts.test.ts src/lib/mcp/skills src/lib/mcp/register.test.tspasses, 18/18. That branch was not modified.