Repository navigation
ci(packaging): shellcheck the packaging scripts and document entry points - #29758
Merged
chrisnojima merged 5 commits intoOct 15, 2026
Merged
chrisnojima merged 5 commits into
chrisnojima merged 5 commits into
Conversation
chrisnojima
added this pull request to stack #29759
October 12, 2026 17:48
zoom-ua
reviewed
Oct 13, 2026
chrisnojima
marked this pull request as ready for review
October 14, 2026 13:50
…y points
- New GitHub workflow runs `shellcheck -S warning -x` over packaging/**/*.sh,
gobuild.sh and packageAndBuild.sh on PRs and master pushes that touch them.
- Fix the warning-level findings: ${BASH_SOURCE[0]}, source directives, unused
variables, a quoted $(...) and trap string, and unquoted URLs in
packageAndBuild.sh whose `&` backgrounded curl.
- packaging/README.md maps each entry script to what launches it and the
environment it reads.
…ndle pre-warm requests non-fatal
chrisnojima
force-pushed
the
nojima/HOTPOT-packaging-shellcheck
branch
from
October 14, 2026 14:01
2678c29 to
2edcc45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Guards the packaging scripts against regressions. Stacked on #29757.
Shellcheck, at the start oftest_linuxin theJenkinsfile, runsshellcheck -S warning -xfrom the repo root overpackaging/**/*.sh,shared/react-native/gobuild.shandpackageAndBuild.sh.Jenkinsfilechanges, using the same change detection as the existing Jenkinsfile-change check.$GOBINand checks its SHA-256. A failed download or checksum mismatch stops the setup before anything is extracted.continuous-integration/jenkins/branch, which is also the check the releasewait-cigate inlib.shwaits on.${BASH_SOURCE[0]}where scripts used bare$BASH_SOURCE;# shellcheck source=directives;$(...)and a quoted trap string;packageAndBuild.sh. Unquoted, the&in them sentcurlto the background and turned the rest of the URL into stray variable assignments. Those pre-warm requests are kept non-fatal. They only run whenpackageAndBuild.shgets platform arguments, andrn:start:legacydoesn't pass any. The constant-wordcasechecks there are now plainiftests that behave the same;linux/deb/layout_repo.shandlinux/rpm/layout_repo.shstay loops, so another architecture can be added, with SC2043 disabled on them.packaging/README.md:KBFS_COMMITis also listed: keybot still sends it, but nothing reads it;lib.shand the Jenkins shellcheck stage.Testing
Jenkinsfile, so theShellcheckstage runs on it.shellcheck; a corrupted checksum fails and extracts nothing.bash -n.