Repository navigation
Improved CMakelists and main.cpp - #2
Open
thenitinshukla wants to merge 2 commits into
Open
thenitinshukla wants to merge 2 commits into
thenitinshukla wants to merge 2 commits into
Conversation
Refactor main function for improved readability and organization. Added constants for screen size, frame rate, and particle counts. Enhanced error handling for font loading.
SamHerts
suggested changes
Aug 19, 2026
SamHerts
left a comment
SamHerts
left a comment
There was a problem hiding this comment.
What does this refactor do exactly? It turns a 150 line file into a 600 line file with too many comments that don't actually provide anything meaningful.
It's better to have more direct commits with meaningful change messages as well as provide information as to why the changes are necessary or good.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code was not compiling on the WSL Linux distro because it was compiled only for macOS. There was also an issue with the font, which has now been fixed.