Repository navigation
Conversation
A test case in `spec/inspect_spec.lua` was failing when run with
LuaJIT on aarch64. The test checks the behavior of `inspect` on
tables with metatables that have the `__metatable` field set.
The failure occurred for the case where `__metatable` was set to
`nil`. The `inspect` function correctly hides the metatable in
this scenario, as `getmetatable` returns `nil`. However, the test
was expecting the metatable to be displayed, and with incorrect
content, causing the assertion to fail.
This commit corrects the failing assertion to expect the correct
output from `inspect`, which is an empty table string `'{}'`.
This aligns the test with the documented behavior of Lua's
`getmetatable` and the current implementation of the library.
Co-developed-by: Gemini gemini-2.5-pro
Co-authored-by: Enrique García Cota <kikito@gmail.com>
Signed-off-by: Matěj Cepl <mcepl@cepl.eu>
[ms: Simplify get_host_architecture]
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A test case in
spec/inspect_spec.luawas failing when run with LuaJIT on aarch64. The test checks the behavior ofinspecton tables with metatables that have the__metatablefield set.The failure occurred for the case where
__metatablewas set tonil. Theinspectfunction correctly hides the metatable in this scenario, asgetmetatablereturnsnil. However, the test was expecting the metatable to be displayed, and with incorrect content, causing the assertion to fail.This commit corrects the failing assertion to expect the correct output from
inspect, which is an empty table string'{}'. This aligns the test with the documented behavior of Lua'sgetmetatableand the current implementation of the library.Co-developed-by: Gemini gemini-2.5-pro
[ms: Simplify get_host_architecture]
See also: #75