Repository navigation
Fix match output for optional nodes in queries with multiple alternatives - #348
Open
matthias-stemmler wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there,
I found another bug (introduced in #299) caused by the confusion between global and alternative-local node indices, similar to #338: In alternatives other than the first, the check whether to include a node in the output uses the wrong index, so when there's an optional node before a non-optional node in such an alternative, the wrong nodes get included. E.g. for
tok | tok? !. lemma, an unrelated node gets included instead of thelemmanode.This PR doesn't include the refactoring mentioned in #338 (comment). Instead, I'm just passing the alternative index (which is available where we need it since #342) along with the alternative-local node index. I also considered using variable names instead of node indices to avoid the confusion altogether, but this would have been too big of a change for this bugfix - it's probably better addressed in a dedicated refactoring.