Skip to content

fix: apply review follow-ups for service accounts, tags and audit log pages - #511

Merged
AlexKantor87 merged 1 commit into
mainfrom
autopilot/2ff19074
Nov 7, 2026
Merged

AlexKantor87 merged 1 commit into
mainfrom
autopilot/2ff19074

Conversation

@mintlify

@mintlify mintlify Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Applies the open review findings from #505, #506 and #507: the roles page now uses the Settings > User Management label, the tags page covers controls (beta) and reading tags with the CLI, and the service accounts page covers listing and revoking keys.

Based on #505, #506 and #507.

@mintlify
mintlify Bot requested a review from a team as a code owner November 7, 2026 10:13
@mintlify
mintlify Bot requested a review from dangrondahl November 7, 2026 10:13
@mintlify

mintlify Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor Author

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
kosli 🟢 Ready View Preview Nov 7, 2026, 10:13 AM

💡 Tip: Enable Automations to automatically generate PRs for you.

@claude

claude Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @mintlify[bot]'s task in 51s —— View job


Doc review: PR #511

I checked the changed lines against the generated reference pages (kosli_list_api-keys, kosli_delete_api-key, kosli_tag, kosli_get_*, terraform-reference/resources/control). All the new internal link targets exist, and membership_audit_log is in navigation. The service-accounts claims match the CLI reference: metadata only, never the key value, and deleting a key also deletes the keys created with it. Nothing else from the Settings > Members label is left anywhere on the site.

administration/managing_tags.md

Improvement: control tagging is announced but not shown in "Tag resources"

  • Location: administration/managing_tags.md:65 and :67-87

  • Issue: The intro, the resource table and the Terraform sentence on line 35 now say controls can be tagged. The section that shows how to do it still covers only flows, environments and repos:

    • The Terraform tab's "full schema" line (65) links only kosli_environment and kosli_flow.
    • The CLI tab has no kosli tag control example.

    A reader who wants to tag a control has to work it out from the reference.

  • Recommendation:

    • Add kosli_control resource to line 65.
    • Add a CLI example such as kosli tag control <CONTROL-IDENTIFIER> --set team=platform. tutorials/working_with_controls.mdx:113 already uses this form.
  • Fix this →

Suggestion: kosli get env is not a documented command name (:186, see the inline comment). Use kosli get environment and link the three get reference pages.


1 Improvement, 1 Suggestion, no Critical findings. This review is advisory. Neither finding blocks the merge.

kosli get repo my-org/my-repo
```

`kosli get flow`, `kosli get env`, and `kosli get control` show tags the same way. [`kosli list repos`](/client_reference/kosli_list_repos) has a `TAGS` column.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: The published command is kosli get environment (reference). An env alias may exist for get, but nothing in the generated reference confirms it. kosli tag env is confirmed only because kosli tag lists it as a resource type. Using the documented name, with links, is safer:

Suggested change
`kosli get flow`, `kosli get env`, and `kosli get control` show tags the same way. [`kosli list repos`](/client_reference/kosli_list_repos) has a `TAGS` column.
[`kosli get flow`](/client_reference/kosli_get_flow), [`kosli get environment`](/client_reference/kosli_get_environment), and [`kosli get control`](/client_reference/kosli_get_control) show tags the same way. [`kosli list repos`](/client_reference/kosli_list_repos) has a `TAGS` column.

@AlexKantor87
AlexKantor87 merged commit 0225846 into main Nov 7, 2026
6 checks passed
@AlexKantor87
AlexKantor87 deleted the autopilot/2ff19074 branch November 7, 2026 10:16

This branch was successfully deployed

1 active deployment
staging — 1d368ad7 Deployed Nov 7, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants