Repository navigation
Startup ordering - #397
Open
rwb27 wants to merge 7 commits into
Open
Startup ordering#397rwb27 wants to merge 7 commits into
rwb27 wants to merge 7 commits into
Conversation
rwb27
force-pushed
the
startup-ordering
branch
from
November 2, 2026 23:30
370fec2 to
34deb08
Compare
rwb27
marked this pull request as ready for review
November 2, 2026 23:30
rwb27
force-pushed
the
startup-ordering
branch
from
November 2, 2026 23:46
34deb08 to
94348ce
Compare
Barecheck - Code coverage reportTotal: 97.39%Your code coverage diff: -0.03% ▾ Uncovered files and lines
|
Also, `attributes` is never used. I've merged it with `class_attributes` to reduce pointless duplication.
This commit adds a `start_first` attribute to `lt.thing_slot` and a simple algorithm that determines the order in which things must be started in order to fulfil those constraints. It's not guaranteed to work, and will give a helpful error if that happens.
This should check that Things get ordered correctly.
Non-deferred Thing Slots now ignore dependencies on the host Thing. This is most likely to happen with a Thing Slot typed as `lt.Thing` which matches all Things on a server. I've added a test for this.
This gets mypy passing again (some failures appeared when I rebased due to a mypy upgrade).
rwb27
force-pushed
the
startup-ordering
branch
from
November 3, 2026 10:25
f91b79e to
0616997
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows
Things to specify that some Thing Slots must be started first. That means the connected Thing will already be running when__enter__is called on the host Thing. This should make it easier to write code that interacts with other Things on start-up.The new syntax looks like the example in #388:
Without
start_first=Truethere is no guarantee thatself.wrappedhas started up, so the function call in__enter__may or may not work.I think, reading my comments back in #388, that
deferred=Falsemight be clearer: I feelstart_firstis ambiguous whether it means start the connected thing first, or start this thing first. I think it's clear thatdeferredrefers to the slot, and so if slots are deferred by default, it means you get no guarantee they've started at the point__enter__is called.Things to do before merge:
deferred=Falseinstead ofstart_first=Trueto enable this behaviour.Closes #388