Skip to content

Update requirements - #408

Merged
bprobert97 merged 2 commits into
mainfrom
update-requirements
Oct 14, 2026
Merged

bprobert97 merged 2 commits into
mainfrom
update-requirements

Conversation

@rwb27

@rwb27 rwb27 commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

This PR updates the pinned dependencies to clear our pip audit warnings.

This should silence the pip audit warnings by updating to the most recent version.
@rwb27
rwb27 requested a review from bprobert97 October 8, 2026 15:56
@bprobert97

Copy link
Copy Markdown
Contributor

I'm happy with the changes - might be worth looking at the 3.13 test failure just to check thats not caused by any package updates?

@rwb27

rwb27 commented Oct 12, 2026

Copy link
Copy Markdown
Collaborator Author

humph, that looks like a mypy improvement has picked up on something. I will do a bit of debugging.

`mypy` now flags my dynamic model creation as incorrectly typed.
I believe this is very close to the issue seen in:
pydantic/pydantic#3585

The solution there was to use a variable typed as `Any` rather than using the argument directly.
As that amounts to a stealthy type: ignore statement, I have opted to use
an explicit type ignore, with a justification.
I think that's clearer.
@barecheck

barecheck Bot commented Oct 13, 2026

Copy link
Copy Markdown

Barecheck - Code coverage report

Total: 97.43%

Your code coverage diff: 0.00% ▴

Uncovered files and lines
FileLines
src/labthings_fastapi/actions.py601-602, 615, 651-652, 853, 994-995, 998, 1001, 1049

@rwb27

rwb27 commented Oct 13, 2026

Copy link
Copy Markdown
Collaborator Author

Thanks @bprobert97. I believe the failing test was due to a new, unfortunate mypy-pydantic interaction. Having checked it out, I think the code is still fine, and mypy is spuriously flagging an error. I have added a type: ignore comment with justification.

I always feel like it's nice to get the nod from someone when I ignore an error like that - so if you didn't mind confirming here that you've seen it and are happy (or saying if you're not) that would be nice.

@bprobert97
bprobert97 merged commit 339abc8 into main Oct 14, 2026
16 checks passed
@bprobert97
bprobert97 deleted the update-requirements branch October 14, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants