Repository navigation
Drop python 3.10 - #411
Draft
rwb27 wants to merge 4 commits into
Draft
Drop python 3.10#411rwb27 wants to merge 4 commits into
rwb27 wants to merge 4 commits into
Conversation
Python 3.10 will be end of life by the time v0.4.0 is released, so I'm removing it from tests, documentation and metadata. This also allows us to re-lock dependencies using Python 3.11, which fixes several vulnerabilities. I assume versions were being held back because other packages already dropped Python 3.10. I've added pip-audit to our dev dependencies, as it's helpful to run it locally and not just in CI.
Since Python 3.11, `Self` is available in the standard library, so there's no need to import it from typing_extensions. This commit swaps the import. It doesn't drop the dependency, as Pydantic still needs us to import TypedDict from typing_extensions.
Collaborator
Author
|
Due to an improvement in Starlette's Given the extensive changes currently pending in #409 I am going to pause this PR. Once #409 is in, I'll rebase and improve the test as part of this PR. |
rwb27
marked this pull request as draft
October 27, 2026 23:49
Starlette's `TestClient` now correctly relays HTTP streams. I have updated this test accordingly. The improved version of this test introduced in #409 will also need updating in due course, but fixing it here untangles the merge ordering.
Barecheck - Code coverage reportTotal: 97.42%Your code coverage diff: -0.01% ▾ Uncovered files and lines |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.10 will be end-of-life by the time v0.4.0 is released. Some dependencies are already dropping support.
This PR drops support for 3.10.
This MR contains the following
Merge checklist:
All new/changed functions have up to date typehints and docstrings.Any changes to the public API have been updated indocs/src/public_api.rst.New or changed features have been added to (or updated in) the conceptual documentation.pyproject.toml).New functionality is fully tested.Any decrease in test coverage has been justified.test-against-ofm-v3job passes, ortest-against-ofm-feature-branchpasses.New features have been used in a branch of the OpenFlexure Microscope, which is tested intest-against-ofm-feature-branch.This code has been tested manually against simulated hardware (detail tests in "Before merge").This code has been tested against real hardware (detail tests in "Before merge").