Log every draft command and replay it - #55
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A draft is built up by commands, some chosen by a model. If the commands are logged the draft can be rebuilt from the source and the log with no model in the loop, which is what makes a run reproducible and a saved run a test.
Every command that changes a draft appends itself to a command log in draft.json, and every field the draft holds carries its provenance: which layer wrote it (1 spec, 2 predicate, 3 range, 4 literal), the source ranges it was copied from, whether it was edited, and by whom.
in2lambda draft replayrebuilds the draft from the source and the log and must produce the same draft.json byte for byte.Done when a draft built by a sequence of commands in a test replays identically, and a replay against a source whose hash has changed is refused.
Workbench ticket t23.