Check maths with KaTeX - #58
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lambda Feedback renders maths with KaTeX in the browser, so maths KaTeX rejects is a fault whatever pdflatex says. Render every maths expression in every field with the katex npm package in strict mode through Node, a recent version pinned in the package, and report each rejection by field, source range and KaTeX's message. The delimiter checks now in in2lambda/validation and the JSON checks of t8 report in the same shape. Node is optional: without it validate says what to install and skips this check, and CI installs it. Done when the test data's KaTeX failure cases are reported and its clean cases are not.
Workbench ticket t29.