Skip to content

feat(api): move skills API to stable namespace - #2063

Merged
tobi12345 merged 3 commits into
mainfrom
codex/python-stable-skills-api
Oct 28, 2026
Merged

tobi12345 merged 3 commits into
mainfrom
codex/python-stable-skills-api

Conversation

@tobi12345

@tobi12345 tobi12345 commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Move the Fern-generated skills API from api.unstable.skills to api.skills for sync and async clients, including optional file content via include_content. Callers must migrate from the unstable namespace.

This is the skills-only migration from #2049. The 20 stable API files are byte-identical to its generated output at ac0c406fa14983b38cefa41e7bc8e48ba0bc5265. The two unstable namespace entry points reuse existing Fern output from before skills were added, removing only skills exports without introducing topics. No generated files were hand-edited; this PR changes generated API files only.

Verification

  • uv run --frozen pytest -n 4 --dist worksteal tests/unit -q with CI test credentials: 974 passed, 2 skipped.
  • Ruff lint, formatting and mypy passed for the generated migration before removal of the extra test; generated code is unchanged.
  • git diff --cached --check: exit 0.

E2E and live-provider tests were skipped for this generated API migration.

@github-actions

Copy link
Copy Markdown

@claude review

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

No review was started: this request came from a bot account. Manual reviews can only be requested by someone with write access to this repository. Ask a maintainer to comment @claude review, or have your automation post the comment from a user account with write access.

Tip: disable this comment in your organization's Code Review settings.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this PR and didn't find any bugs. It adds about 3,000 lines of generated code and a new stable public SDK surface (langfuse.api.skills), so a maintainer should still confirm that exposing this resource as stable is intended.

What was reviewed:

  • How skills is hooked into LangfuseAPI/AsyncLangfuseAPI in langfuse/api/client.py. It is lazy-loaded with TYPE_CHECKING imports, the same way the existing resources are.
  • The sync and async raw clients. Both use the same api/public/skills/... paths and send include_content as the includeContent query param.
  • The tests in tests/unit/test_api_skills.py. They cover stable get with and without content, and check that the legacy unstable.skills route still works.
Extended reasoning...

This PR only adds code: a new Fern-generated skills package under langfuse/api, its exports and client wiring, and one unit test file. It touches no auth, crypto or permission code; the new clients send HTTP requests through the existing client wrapper. No bugs were found, and the sync and async paths and params match. I deferred instead of approving because the change is large (3,076 lines) and creates a new stable public API, which is a product decision a maintainer should confirm. CODEOWNERS covers only .github/, so no owners are assigned to these paths.

Comment thread langfuse/api/skills/client.py
Comment thread langfuse/api/skills/client.py
Comment thread langfuse/api/client.py
@tobi12345
tobi12345 force-pushed the codex/python-stable-skills-api branch from a6a7e27 to e6d1654 Compare October 28, 2026 13:55
@tobi12345 tobi12345 changed the title feat(api): expose stable skills client feat(api)!: move skills API to stable namespace Oct 28, 2026
@tobi12345 tobi12345 changed the title feat(api)!: move skills API to stable namespace feat(api): move skills API to stable namespace Oct 28, 2026
@tobi12345

Copy link
Copy Markdown
Contributor Author

@claude reveiw

@tobi12345
tobi12345 merged commit cb88960 into main Oct 28, 2026
31 of 32 checks passed
@tobi12345
tobi12345 deleted the codex/python-stable-skills-api branch October 28, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant