Repository navigation
feat(api): move skills API to stable namespace - #2063
Conversation
|
@claude review |
There was a problem hiding this comment.
Claude Code Review
No review was started: this request came from a bot account. Manual reviews can only be requested by someone with write access to this repository. Ask a maintainer to comment @claude review, or have your automation post the comment from a user account with write access.
Tip: disable this comment in your organization's Code Review settings.
There was a problem hiding this comment.
I reviewed this PR and didn't find any bugs. It adds about 3,000 lines of generated code and a new stable public SDK surface (langfuse.api.skills), so a maintainer should still confirm that exposing this resource as stable is intended.
What was reviewed:
- How
skillsis hooked intoLangfuseAPI/AsyncLangfuseAPIinlangfuse/api/client.py. It is lazy-loaded with TYPE_CHECKING imports, the same way the existing resources are. - The sync and async raw clients. Both use the same
api/public/skills/...paths and sendinclude_contentas theincludeContentquery param. - The tests in
tests/unit/test_api_skills.py. They cover stablegetwith and without content, and check that the legacyunstable.skillsroute still works.
Extended reasoning...
This PR only adds code: a new Fern-generated skills package under langfuse/api, its exports and client wiring, and one unit test file. It touches no auth, crypto or permission code; the new clients send HTTP requests through the existing client wrapper. No bugs were found, and the sync and async paths and params match. I deferred instead of approving because the change is large (3,076 lines) and creates a new stable public API, which is a product decision a maintainer should confirm. CODEOWNERS covers only .github/, so no owners are assigned to these paths.
a6a7e27 to
e6d1654
Compare
|
@claude reveiw |
What does this PR do?
Move the Fern-generated skills API from
api.unstable.skillstoapi.skillsfor sync and async clients, including optional file content viainclude_content. Callers must migrate from the unstable namespace.This is the skills-only migration from #2049. The 20 stable API files are byte-identical to its generated output at
ac0c406fa14983b38cefa41e7bc8e48ba0bc5265. The two unstable namespace entry points reuse existing Fern output from before skills were added, removing only skills exports without introducing topics. No generated files were hand-edited; this PR changes generated API files only.Verification
uv run --frozen pytest -n 4 --dist worksteal tests/unit -qwith CI test credentials: 974 passed, 2 skipped.git diff --cached --check: exit 0.E2E and live-provider tests were skipped for this generated API migration.