Skip to content

chore: add cla gate - #2065

Merged
hassiebp merged 2 commits into
mainfrom
add-cla-gate
Oct 27, 2026
Merged

hassiebp merged 2 commits into
mainfrom
add-cla-gate

Conversation

@hassiebp

@hassiebp hassiebp commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; no blocking issue was found.

Summary

Adds a GitHub Actions workflow that publishes CLA gate for pull requests and the merge queue.

  • Pull requests get a CLA gate status based on contributor access or a signed CLA.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Workflow event] --> B{Merge group?}
  B -->|Yes| C[Publish success]
  B -->|No| D[Find matching open PRs]
  D --> E{All contributors exempt?}
  E -->|Yes| C
  E -->|No| F{Trusted CLA status successful?}
  F -->|Yes| C
  F -->|No| G[Publish failure]
Loading

Reviews (2) · Last reviewed commit: "chore: add cla gate" · Reviewed by Greptile

@hassiebp
hassiebp requested a review from a team as a code owner October 27, 2026 10:42
@github-actions

Copy link
Copy Markdown

@claude review

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

No review was started: this request came from a bot account. Manual reviews can only be requested by someone with write access to this repository. Ask a maintainer to comment @claude review, or have your automation post the comment from a user account with write access.

Tip: disable this comment in your organization's Code Review settings.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T11:08:54.890508Z ff4f310 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ff71291df3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/cla-gate.yml
@hassiebp
hassiebp enabled auto-merge (squash) October 27, 2026 10:47

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beyond the inline findings, I checked two more things and found no problem. First, the workflow runs on pull_request_target, so I looked for script injection. It never checks out PR code, and the github-script body reads PR data through context.payload instead of ${{ }} interpolation. The only interpolation is in the concurrency group key. Second, listCommitStatusesForRef returns statuses newest first, so the find picks up the most recent license/cla status from that creator, not an old one.

Extended reasoning...

This adds one new GitHub Actions workflow on the pull_request_target, merge_group and status triggers. It publishes a commit status that is meant to become a required check, so it controls merge gating. This note only lists what was checked beyond the inline findings, which are left as they are.

Findings marked 🟡 are optional suggestions and need no follow-up push.

Comment thread .github/workflows/cla-gate.yml
Comment thread .github/workflows/cla-gate.yml
@hassiebp
hassiebp disabled auto-merge October 27, 2026 10:55
@hassiebp
hassiebp marked this pull request as draft October 27, 2026 10:56
@hassiebp
hassiebp marked this pull request as ready for review October 27, 2026 10:56

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review completed

Nothing new to post: everything this review found is already covered by existing comments on this pull request or didn't merit a separate one.

@hassiebp
hassiebp merged commit 1558163 into main Oct 27, 2026
17 of 18 checks passed
@hassiebp
hassiebp deleted the add-cla-gate branch October 27, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants