Repository navigation
fix(langchain): avoid double counting Anthropic cache writes - #2070
Open
chelsealong wants to merge 1 commit into
Open
chelsealong wants to merge 1 commit into
chelsealong wants to merge 1 commit into
Conversation
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes langfuse/langfuse#19452.
Map Anthropic’s 5-minute and 1-hour cache writes to their usage buckets and retain only unattributed writes in
cache_creation_input_tokens. This prevents the aggregate and tier counts from counting the same tokens twice.The reported example now totals 5,701 tokens instead of 11,245. Regression tests cover that example, an unattributed remainder, missing aggregate, and zero-value tiers.
Prepared with Codex assistance.
Type of change
Verification
Checklist


Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
Maps Anthropic’s cache writes to separate 5-minute and 1-hour buckets. Only writes not covered by those buckets remain in
cache_creation_input_tokens.Reviews (1) · Last reviewed commit: "fix(langchain): avoid double counting An..." · Reviewed by Greptile