Repository navigation
test(prompt): use explicit test credentials in test_prompt fixture - #2072
Open
AsherLucas wants to merge 1 commit into
Open
AsherLucas wants to merge 1 commit into
AsherLucas wants to merge 1 commit into
Conversation
Fixes langfuse#1976: CONTRIBUTING says unit tests need no running server, but the langfuse fixture called Langfuse() with no arguments, so without LANGFUSE_* env vars the client was disabled and setting .api raised AttributeError. Use the dummy credentials CI already uses so the fixture initializes and the 18 erroring tests pass on a fresh clone.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1976.
CONTRIBUTING says unit tests need no running server, but on a fresh clone without LANGFUSE_* env vars the
langfusefixture intests/unit/test_prompt.pycalledLangfuse()with no arguments. The client then initializes disabled, and setting.api = Mock()raisesAttributeError: Langfuse client is not initialized, erroring 18 tests.Use the dummy credentials CI already uses (
pk-lf-test/sk-lf-test,http://localhost:3000) so the fixture initializes on a fresh clone. No SDK behaviour change.Before:
pytest tests/unit/test_prompt.py -q-> 8 passed, 18 errors (no LANGFUSE_* env vars).After: 26 passed.
This PR appears safe to merge.Summary
The prompt-test fixture now supplies dummy credentials and a localhost URL.
Reviews (1) · Last reviewed commit: "test(prompt): use explicit test credenti..." · Reviewed by Greptile