Repository navigation
fix: align README with env-var setup and restore missing client-side ID guard - #19
Merged
Merged
Conversation
…ID guard Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
Author
|
@cursor review |
kinyoklion
marked this pull request as ready for review
September 15, 2026 16:39
kinyoklion
approved these changes
Sep 15, 2026
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
@cursor review |
joker23
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a stale README and a dead client-side-ID guard in this example, and makes the SDK constraint float within its current major instead of across majors.
index.jsvariables (environmentId) that do not exist; it now documentsLAUNCHDARKLY_CLIENT_SIDE_ID/LAUNCHDARKLY_FLAG_KEYand the output the app actually prints, matching hello-node-server.'your-client-side-id'; without the env var the example failed with an opaque SDK error instead.launchdarkly-node-client-sdkconstraint now floats within major 3 rather than across all future majors, so patch/minor releases need no PR while a 4.x release still requires a deliberate change:package-lock.jsonis gitignored), sonpm installstill resolves to the latest 3.x (currently 3.4.3). No SDK version bump was needed and no deprecated SDK APIs are used.fix:because it touches shipped example code.Implementation details
GitHub Actions pins in
.github/workflowsare deliberately left alone (SHA/major pins for supply-chain reasons), and the README documents no version requirement, so it was not touched for the constraint change.launchdarkly-node-client-sdkis the repo's only dependency.Verification on the branch:
Re-running the success case under
node --trace-deprecation --pending-deprecationproduced no deprecation warnings. Node console app, so no screenshots.Link to Devin session: https://app.devin.ai/sessions/122470ac980d492a860e21c8062ac5c7
Open in Devin Desktop: https://app.devin.ai/desktop/session/122470ac980d492a860e21c8062ac5c7?variant=devin