Repository navigation
chore: Bump launchdarkly/gh-actions from verify-hello-app-v2.0.2 to 2.0.1 #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,7 +33,7 @@ jobs: | |
| - name: Install dependencies | ||
| run: poetry install | ||
|
|
||
| - uses: launchdarkly/gh-actions/actions/verify-hello-app@verify-hello-app-v2.0.2 | ||
| - uses: launchdarkly/gh-actions/actions/verify-hello-app@verify-hello-app-v2.0.1 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔒 Agentic Security Review Severity: CRITICAL Description: The CI downgrade from verify-hello-app-v2.0.2 to verify-hello-app-v2.0.1 selects release-secrets v1.2.0, whose AWS credential step is aws-actions/configure-aws-credentials@v4. That tag is an annotated floating ref ("This tag will always track the latest v4 release") and currently points at 7474bc4690e29a8392af63c5b98e7449536d5c3a, not the v6 commit e7f100cf4c008499ea8adda475de1042d6975c7b pinned by release-secrets v1.2.1. The build-and-run job has id-token: write and passes vars.AWS_ROLE_ARN into that step with audience https://github.com/launchdarkly, so whoever next moves v4 executes their code in this job and receives the OIDC token and role ARN. Impact: This PR adds a new public-artifact trust for the step that mints the GitHub OIDC token and assumes vars.AWS_ROLE_ARN. v2.0.2 kept that step on a commit SHA, so a later move of aws-actions/configure-aws-credentials v4 could not change it. v2.0.1 resolves the credential action at runtime, and the daily schedule plus pull_request runs will execute the new target without another edit to this repo. The same job is already able to assume that role and read the hello-app SSM parameters, including /sdk/common/hello-apps/server-key into LAUNCHDARKLY_SDK_KEY. A moved v4 tag therefore gets the workflow's AWS role credentials and the SDK key. The outer verify-hello-app tag was already controlled by launchdarkly/gh-actions; v4 is a separate upstream publisher that the previous SHA pin did not trust. Remediation: Revert the workflow pin to launchdarkly/gh-actions/actions/verify-hello-app@verify-hello-app-v2.0.2 so the job keeps release-secrets v1.2.1 and the credential step stays on commit e7f100cf4c008499ea8adda475de1042d6975c7b. If a newer verify-hello-app is required, use one whose nested release-secrets action pins aws-actions/configure-aws-credentials to a reviewed full commit SHA, not the moving v4 tag. |
||
| with: | ||
| use_server_key: true | ||
| role_arn: ${{ vars.AWS_ROLE_ARN }} | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Action version incorrectly downgraded
High Severity
The workflow pin moves
verify-hello-appfromv2.0.2tov2.0.1, which is an older tag, not a newer one.v2.0.2(Nov 2026) updated the action to Node.js 24;v2.0.1is from Aug 2024. Merging this reverts that update and leaves CI on a stale action.Reviewed by Cursor Bugbot for commit 95b7a47. Configure here.