Repository navigation
chore(deps-dev): bump eslint from 8.57.0 to 10.13.0 in /internal/dev_server/ui - #974
dependabot[bot] wants to merge 1 commit into
Conversation
dependabot
Bot
added
the
dependencies
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 283da5a. Configure here.
| "@typescript-eslint/parser": "7.13.1", | ||
| "@vitejs/plugin-react": "4.5.0", | ||
| "eslint": "8.57.0", | ||
| "eslint": "10.13.0", |
There was a problem hiding this comment.
ESLint 10 breaks React plugin
High Severity
Bumping eslint to 10.13.0 leaves eslint-plugin-react at 7.37.4, which only peers eslint through ^9.7. ESLint 10 removed context.getFilename(), so the recommended React rules used in eslint.config.js crash (typically contextOrFilename.getFilename is not a function). npm run lint and the UI CI lint job fail.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 283da5a. Configure here.
283da5a to
889cc30
Compare
|
@dependabot rebase |
Bumps [eslint](https://github.com/eslint/eslint) from 8.57.0 to 10.13.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v8.57.0...v10.13.0) --- updated-dependencies: - dependency-name: eslint dependency-version: 10.13.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
889cc30 to
ece99fb
Compare
|
Closing for now: needs a dev-server UI eslint toolchain cleanup (drop unused @typescript-eslint v7 / react-hooks / react-refresh deps) before eslint 9+ will install. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps eslint from 8.57.0 to 10.13.0.
Release notes
Sourced from eslint's releases.
... (truncated)
Commits
4637f9810.13.096df05cBuild: changelog update for 10.13.04783a68docs: Update READMEb59d889chore: update github/codeql-action action to v4.38.3 (#21412)95e51a0ci: re-enable@typescript-eslint/typescript-eslintin ecosystem tests (#21410)317fcb3chore: update ecosystem plugins (#21409)48d5cc4feat: report references inside IIFEs inno-use-before-define(#21238)43f0ac9docs: clarify parameter description ingetText(#21287)a39d9fbfeat: addglobalThistono-obj-calls(#21382)b92decfperf: skip no-redeclare scan for single-declaration variables (#21365)Maintainer changes
This version was pushed to npm by eslintbot, a new releaser for eslint since your current version.
Note
Overview
Upgrades the eslint dev dependency in
internal/dev_server/uifrom 8.57.0 to 10.13.0, with a matching package-lock.json refresh. ESLint 10 pulls in a new lint stack (e.g.@eslint/config-array,@humanfs/node, updated espree / eslint-scope) and drops legacy pieces such as @eslint/eslintrc and doctrine that shipped with ESLint 8.There are no source or ESLint config file edits in this PR—the UI already uses flat
eslint.config.js, which aligns with ESLint 9+. Impact is limited tonpm run lintand local/CI Node versions: ESLint 10 expects Node ^20.19.0, ^22.13.0, or ≥24. Worth confirming lint still passes given older@typescript-eslint/*7.x packages still declare eslint ^8 peers alongsidetypescript-eslint8.x.Reviewed by Cursor Bugbot for commit ece99fb. Bugbot is set up for automated code reviews on this repo. Configure here.