Skip to content

chore: Bump GitHub Actions to their Node.js 24 versions - #133

Merged
keelerm84 merged 3 commits into
mainfrom
mk/SDK-3651/node24-actions
Nov 19, 2026
Merged

keelerm84 merged 3 commits into
mainfrom
mk/SDK-3651/node24-actions

Conversation

@keelerm84

@keelerm84 keelerm84 commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Summary

GitHub has deprecated the Node.js 20 runtime for JavaScript actions, and workflows in this repository print a deprecation warning on every run. This PR bumps each action that runs on Node.js 20 or older to its latest major release, which runs on Node.js 24. Tag pins stay tag pins. SHA pins move to the SHA of the new release, with a version comment.

Action From To
actions/checkout v4 v7
leafo/gh-actions-lua 35bcb06 32909a2 (v13.1.0)
leafo/gh-actions-luarocks e65774a 1c4a92c (v6.1.1)
luarocks/gh-actions-lua c1e8c4a 56eba09 (v14)
luarocks/gh-actions-luarocks 8acd6db 95d2308 (v7)
robinraju/release-downloader efa4cd0 28fc21f (v1.13)

None of the bumps change the inputs this repository passes.

Behavior changes to know about:

  • actions/checkout v6 and later store the persisted credentials in a separate file under $RUNNER_TEMP, not in .git/config.

It also bumps verify-hello-app to verify-hello-app-v2.0.2, which calls release-secrets-v1.2.1 (Node.js 24) in place of release-secrets-v1.2.0 (Node.js 20 actions).

Opened from termag


Note

Overview
Upgrades GitHub Actions and composite dependencies from Node.js 20–era releases to current majors that run on Node.js 24, eliminating deprecation warnings on workflow runs.

actions/checkout is bumped from v4 to v7 everywhere workflows and composite actions check out the repo (CI, release, docs, manual publish/install flows). Lua/LuaRocks setup uses newer pins: luarocks/gh-actions-lua (v14) and luarocks/gh-actions-luarocks (v7) in the shared CI action, and leafo/gh-actions-lua (v13.1.0) / leafo/gh-actions-luarocks (v6.1.1) in install-lua-sdk. robinraju/release-downloader moves to v1.13 for C++ SDK downloads.

Example verification steps now use verify-hello-app-v2.0.2, which in turn pulls a Node 24–compatible release-secrets release. Step inputs are unchanged; note that checkout v6+ stores persisted credentials under $RUNNER_TEMP instead of .git/config if anything in the repo relied on the old behavior.

Reviewed by Cursor Bugbot for commit 80b91a3. Bugbot is set up for automated code reviews on this repo. Configure here.

@keelerm84
keelerm84 requested a review from a team as a code owner November 17, 2026 19:04

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: medium.

Automated risk review (dry run): Medium

This PR would not be automatically approved. Human approval required.

Why: It updates CI workflow definitions and composite GitHub Actions under .github/workflows and .github/actions, including actions/checkout v4 to v7 and SHA pins used by release and publish jobs. CI workflow changes are never Low, so this stays Medium even though Bugbot completed with no findings.

If you disagree with this review, share this PR in #feedback-agent-approvals or submit a changes-requested review explaining why.

Open in Web View Automation 

Sent by Cursor Approval Agent: Dry-Run PR Approver

@cursor cursor Bot added the risk:medium label Nov 17, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5c9500f. Configure here.

Comment thread .github/actions/ci/action.yml Resolved
@keelerm84
keelerm84 merged commit da1dc1f into main Nov 19, 2026
20 checks passed
@keelerm84
keelerm84 deleted the mk/SDK-3651/node24-actions branch November 19, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants