Repository navigation
fix: Require C++ server SDK 3.15.2 so that wrong-type evaluations record the default value in events - #134
Merged
Conversation
…ord the default value in events Generated-by: termag
There was a problem hiding this comment.
Risk: medium.
Automated risk review (dry run): Medium
This PR would not be automatically approved. Human approval required.
Why: This bump of the C++ server SDK to 3.15.2 and Redis source to 2.4.5 also changes CI version pins in .github/variables/cpp-sdk-versions.env and deployment Dockerfiles under contract-tests/ and examples/, which cannot be Low. Human review is needed and no reviewers were assigned.
If you disagree with this review, share this PR in #feedback-agent-approvals or submit a changes-requested review explaining why.
Sent by Cursor Approval Agent: Dry-Run PR Approver
kinyoklion
approved these changes
Nov 18, 2026
kinyoklion
pushed a commit
that referenced
this pull request
Nov 20, 2026
🤖 I have created a release *beep* *boop* --- ## [2.2.1](v2.2.0...v2.2.1) (2026-11-19) ### Bug Fixes * Prevent a crash when track is called with nil data ([#130](#130)) ([fa3e0d8](fa3e0d8)) * Require C++ server SDK 3.15.0 so that track sends metric values correctly ([#132](#132)) ([7bbc9cc](7bbc9cc)) * Require C++ server SDK 3.15.2 so that wrong-type evaluations record the default value in events ([#134](#134)) ([3043105](3043105)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Overview** > Cuts **patch release 2.2.1** by sweeping version references from **2.2.0** through release tooling: `release-please` manifest, `CHANGELOG`, LuaRocks rockspecs (base + Redis) with `v2.2.1` source tags, `SDKVersion` in `launchdarkly-server-sdk.c`, helper scripts, README `luarocks make` examples, and example Docker `ARG VERSION` values. > > No new functional code appears in this diff; **2.2.1** is documented as fixing a **`track` crash when `data` is nil**, correct **metric** behavior via C++ server SDK **3.15.0+**, and **wrong-type evaluation events** recording defaults via C++ **3.15.2+** (those fixes ship in commits referenced by the changelog). > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 7a54ce2. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: LaunchDarklyReleaseBot <LaunchDarklyReleaseBot@launchdarkly.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
With C++ server SDK versions before 3.15.1, a typed evaluation (
boolVariation,intVariation,doubleVariation,stringVariationand their detail forms) that got a flag value of the wrong type returned the default value, but the analytics event recorded the flag value and its variation (cpp-sdks#643). This raises the documented minimums to C++ server SDK 3.15.2 and Redis source 2.4.5, and moves CI, the contract test service and the examples to those versions.The "wrong type evaluation events" contract tests in sdk-test-harness 2.46.0 check this. Tested locally with the contract test service: on C++ server SDK 3.15.0, 16 of the 20 wrong-type tests fail. On 3.15.2 all 20 pass, and the full v2 suite passes with the existing suppressions (5349 tests).
Opened from termag
Note
Overview
Raises the minimum LaunchDarkly C++ server SDK from 3.15.0 → 3.15.2 and the optional Redis source from 2.4.3 → 2.4.5, so typed evaluations that receive a value of the wrong type both return the default and record that default in analytics events (fixed upstream in cpp-sdks).
The version bump is applied in
.github/variables/cpp-sdk-versions.env(which feeds CI build args), the README dependency table, and Dockerfiles for contract tests and the hello-debian, hello-haproxy, and hello-nginx examples.Reviewed by Cursor Bugbot for commit d472462. Bugbot is set up for automated code reviews on this repo. Configure here.