Skip to content

TRY updating params instead of waiting on mutex - #74

Open
Nibanovic wants to merge 1 commit into
learnsyslab:mainfrom
Nibanovic:fix/dont-get-params-in-update
Open

Nibanovic wants to merge 1 commit into
learnsyslab:mainfrom
Nibanovic:fix/dont-get-params-in-update

Conversation

@Nibanovic

Copy link
Copy Markdown

In this PR we replace refresh_dynamic_parameters and get_params with the RT safe try_update_params().

Before:

We had watchdog breaks at 1000hz, for both controllers, seemingly at random times. This was indicating a mutex contention somewhere
image

After:

we're stasbilized back to ~100us for all update() cycles.
image

Note: If you want to inspect the *_params.hpp header for these functions, check the install/crisp_controller dir, it is auto-generated heade.

@destogl destogl left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is the right was to handle RT. We should do the same in the Admittance Controller in the ros2_controllers repository.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants