Skip to content

Use public headers in Cartesian controllers and broadcasters - #75

Open
BanSangSu wants to merge 1 commit into
learnsyslab:mainfrom
BanSangSu:fix/public-eigen-header
Open

BanSangSu wants to merge 1 commit into
learnsyslab:mainfrom
BanSangSu:fix/public-eigen-header

Conversation

@BanSangSu

Copy link
Copy Markdown

Summary

This PR replaces internal/private Eigen include paths with the corresponding public Eigen headers in the Cartesian controllers and broadcasters.

The previous includes relied on Eigen implementation details that are not guaranteed to be available through the public installation layout and can cause downstream builds to fail depending on how Eigen is packaged.

Changes

  • Replace internal Eigen header usage with supported public Eigen headers.
  • Apply the fix consistently across the Cartesian controllers and related broadcasters.
  • Keep controller behavior and runtime semantics unchanged.

Motivation

Consumers of crisp_controllers should only depend on Eigen's public API. Using public headers improves portability across distributions and Eigen packaging layouts and avoids relying on implementation-specific include paths.

Testing

  • Verified that the affected controllers and broadcasters compile successfully with the public Eigen headers.
  • Verified plugin loading/instantiation for the affected CRISP components.
  • No controller API or control-law behavior is changed by this PR.

Scope

This is a build/compatibility fix only. It does not change controller behavior, ROS interfaces, parameters, or runtime semantics.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant