Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces internal/private Eigen include paths with the corresponding public Eigen headers in the Cartesian controllers and broadcasters.
The previous includes relied on Eigen implementation details that are not guaranteed to be available through the public installation layout and can cause downstream builds to fail depending on how Eigen is packaged.
Changes
Motivation
Consumers of
crisp_controllersshould only depend on Eigen's public API. Using public headers improves portability across distributions and Eigen packaging layouts and avoids relying on implementation-specific include paths.Testing
Scope
This is a build/compatibility fix only. It does not change controller behavior, ROS interfaces, parameters, or runtime semantics.