Skip to content

Pin Linux x64 qualification and release builders to Ubuntu 24.04 #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leehack merged 1 commit into from
Nov 2, 2026
Merged

Pin Linux x64 qualification and release builders to Ubuntu 24.04 #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/native_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ jobs:
- { target: ios-arm64-sim, runs_on: macos-latest }
- { target: ios-x64-sim, runs_on: macos-latest }
- { target: android-arm64, runs_on: ubuntu-latest }
- { target: linux-x64, runs_on: ubuntu-latest, smoke: "--expect-device CPU" }
- { target: linux-x64-vulkan, runs_on: ubuntu-latest, smoke: "--expect-device Vulkan" }
- { target: linux-x64, runs_on: ubuntu-24.04, smoke: "--expect-device CPU" }
- { target: linux-x64-vulkan, runs_on: ubuntu-24.04, smoke: "--expect-device Vulkan" }
- { target: linux-arm64, runs_on: ubuntu-24.04-arm, smoke: "--expect-device CPU" }
- { target: linux-arm64-vulkan, runs_on: ubuntu-24.04-arm, smoke: "--expect-device Vulkan" }
- { target: windows-x64, runs_on: windows-2022, smoke: "--expect-device CPU" }
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/validate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@ jobs:
- { target: ios-arm64-sim, runs_on: macos-latest }
- { target: ios-x64-sim, runs_on: macos-latest }
- { target: android-arm64, runs_on: ubuntu-latest }
- { target: linux-x64, runs_on: ubuntu-latest, smoke: "--expect-device CPU" }
- { target: linux-x64-vulkan, runs_on: ubuntu-latest, smoke: "--expect-device Vulkan" }
- { target: linux-x64, runs_on: ubuntu-24.04, smoke: "--expect-device CPU" }
- { target: linux-x64-vulkan, runs_on: ubuntu-24.04, smoke: "--expect-device Vulkan" }
- { target: windows-x64, runs_on: windows-2022, smoke: "--expect-device CPU" }
- { target: windows-x64-vulkan, runs_on: windows-2022, smoke: "--expect-device CPU" }
steps:
Expand Down
12 changes: 12 additions & 0 deletions tests/test_release_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,18 @@ def test_preparation_has_no_release_write_path(self):
self.assertIn(" contents: write\n", job_header)
self.assertEqual(workflow.count("action-gh-release@"), 1)

def test_linux_runtime_builds_keep_the_qualified_ubuntu_baseline(self):
# The floating label moved to Ubuntu 26.04 and a different software
# Vulkan matrix path; qualification and release must use one baseline.
for name in ("validate.yml", "native_release.yml"):
workflow = (ROOT / ".github/workflows" / name).read_text()
for target in ("linux-x64", "linux-x64-vulkan"):
with self.subTest(workflow=name, target=target):
self.assertRegex(
workflow,
rf"target: {target}, runs_on: ubuntu-24\.04,",
)

def test_normal_release_mode_remains_explicit_and_enabled(self):
workflow = (ROOT / ".github/workflows/native_release.yml").read_text()
self.assertIn(
Expand Down
Loading