Repository navigation
feat: add cpr::to_string for ErrorCode and deprecate std::to_string overload - #1333
Open
officialjisanhalder-art wants to merge 1 commit into
Open
officialjisanhalder-art wants to merge 1 commit into
officialjisanhalder-art wants to merge 1 commit into
Conversation
COM8
requested changes
Oct 18, 2026
COM8
left a comment
COM8
left a comment
Member
There was a problem hiding this comment.
@officialjisanhalder-art thanks! Only one comment.
|
|
||
| } // namespace cpr | ||
|
|
||
| // NOLINTBEGIN(cert-dcl58-cpp) required for to_string |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When constructing a multipart form payload with empty header keys, CPR attempted to access null string views, causing undefined behavior or crashes in debug iterators.
Changes
Testing
Fixes #1332