Repository navigation
Move the README's SQLite section into Connecting, as the other two READMEs keep no store's section - #460
Merged
Conversation
…ADMEs keep no store's section
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README's "SQLite" section (added in #374) moves out: what it said, a graph in a file and what a transaction gives there, was already in Connecting, SQLite, at more length. The README keeps the
pip install drivine # SQLite 3.45 or later…line and one link to that section, so it holds only installation, a quick start, the documentation links and the licence, as Drivine for TypeScript's and drivine4j's READMEs do.Two lines in Connecting's "What a transaction gives" are corrected against the code:
patch_oneandpatch_allgo through_when_uncontendedindrivine/manager/stateless_graph_object_manager.py, assaveanddeletedo.sqlite3.connectwas said to have no log and no busy timeout. It does write ahead to the log, as SQLite keeps WAL mode in the file once Drivine sets it, and Python'ssqlite3waits 5 seconds for a locked file by default. What it lacks is the foreign keys,BEGIN IMMEDIATE, the long-lock warning, the 30-second wait and Drivine's functions.Nothing linked to the README's
#sqliteanchor: not docs/, the site's import (drivine'swebsite/scripts/import-readmes.mjs, which reads docs/), nor the other two READMEs. The site builds with these docs (DRIVINE_PYTHON_DOCS=docs npm run import-readmes && astro buildin drivine's website/), and drivine.org/py/connecting/ has the corrected lines.