Skip to content

feat(native): edit review comments before they are sent - #910

Merged
omartelo merged 2 commits into
mainfrom
feat/edit-review-comments
Oct 22, 2026
Merged

omartelo merged 2 commits into
mainfrom
feat/edit-review-comments

Conversation

@omartelo

@omartelo omartelo commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Session review batch: each comment's row has a pencil beside its ×, which opens the comment in a dialog with a textarea, so a long comment is edited whole instead of squeezed into the one-line row. Save or Ctrl+Enter files it, Cancel or Escape keeps the old text. The dialog is one per window (commentEditDialog, laid out with the other dialogs) since the Review tab, the Code tab and a pull request's files share the batch through commentStore; the store holds which comment is being edited, and the dialog closes if that comment is removed. The terminal stays off the keyboard while it is open.
  • Pull request pending review: each line comment gets an Edit button beside Discard. It opens the comment in a textarea shaped like a thread's reply box: Save or Ctrl+Enter files the new body, Cancel keeps the old. Discarding any comment closes an open edit, since the comments are keyed by index.
  • commentBatch.remove is gone in favour of the existing clickableAt.
  • New keys diff.commentEdit.title, diff.commentEdit.save, pulls.pullsConversation.edit and .save in every locale.

Test plan

  • TestCommentBatchEditsOneInPlace, TestCommentEditFollowsTheCommentItWasOpenedOn and TestPendingReviewEditsOneComment
  • native/: gofmt -l ., go vet ./..., go test ./...

A comment in the session's review batch is reworded in place by clicking
its text. A line comment in a pull request's pending review gets an Edit
button beside Discard that opens it in a box, saved with Save or Ctrl+Enter.
The inline field squeezed a long comment into the batch's one-line row.
A pencil beside the × now opens the comment in a textarea dialog, one per
window since the Review tab, the Code tab and a pull request's files share
the batch; Save or Ctrl+Enter files it.
@omartelo
omartelo force-pushed the feat/edit-review-comments branch from cdd8e12 to 90d67c0 Compare October 22, 2026 19:56
@omartelo
omartelo merged commit d5f1bfa into main Oct 22, 2026
7 checks passed
@omartelo
omartelo deleted the feat/edit-review-comments branch October 22, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant