Repository navigation
fix(native): open the active session from a pull request's checkout - #914
Merged
Merged
Conversation
omartelo
force-pushed
the
fix/pulls-go-to-active-session
branch
from
October 22, 2026 20:16
b0d6adc to
4aad5e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On the Pulls screen, Go to session on a pull request whose checkout holds several sessions always opened the first of them, even when the session you were in sat in that checkout.
(*model).sessionToOpenAtpicks the session to bring up for a checkout: the window's active session when it sits there, the first otherwise.prSessionreads it instead ofsessionsAt(...)[0].CHANGELOG.md[Unreleased]› Fixed entry.#913 applies the same rule to where a pull request's review comments go (
pullsScreen.reviewSession). Once both are in,reviewSessioncan readsessionToOpenAt.Test plan
native/:gofmt -l .clean,go vet ./...andgo test ./...greenTestSessionToOpenAtPrefersTheActiveSession: fails on the oldids[0]ruleTestSessionToOpenAtFallsBackToTheFirstSession: active session in another project, checkout with no sessions