Repository navigation
fix(native): show a card's status line in place of its path - #929
Merged
Merged
Conversation
The tool, Waiting, relay and compacting line was added above the path, so a card grew by a line when a turn started and shrank when it ended, pushing every card below it. The line now takes the path's place while it shows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A session card grew by a line when its agent started a tool, waited on the user, opened a relay or compacted, and shrank when that ended. Every card below it jumped each time.
The status line (
statusRung) now takes the place of the card's path while it shows, so the card keeps one height through a turn. The path, and the layout chip that sits on its line, come back when the status line goes.Test plan
TestCardKeepsItsHeightWhileTheStatusRungShowslays a card out at rest, running a tool and waiting, and checks they are the same height. It failed before the change (110px against 86px).gofmt -l .,go vet ./...andgo test ./...innative/.