Repository navigation
fix(native): end a tab drag that can no longer hear its drop - #934
Merged
Merged
Conversation
A keyboard drag listens for Space and Escape only on the focused item, so once focus moved elsewhere the tab stayed lifted for good and every other press was ignored. A pointer drag whose Sortable turned Disabled mid-drag (a layout tab's rename) lost its release the same way. Both now end the drag without dropping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A top bar tab could get stuck lifted (accent fill, detached shape) until lich restarted, and no tab could be dragged again.
pointerignores every press whileactiveis set. The drag now ends, dropping nothing, when its item loses focus.Sortable.Disabled, which lays the items out without a handler, so the release of a drag already in the air never arrived.Updatenow ends the drag when the Sortable is disabled.Test plan
TestSortableKeyboardDragEndsWhenFocusLeavesandTestSortableDisabledMidDragEndsItfail without the fix and pass with it.native/:gofmt -l .,go vet ./...,go test ./...clean.