Tokio runtime shutdown does not abort tasks created via spawn_blocking

In case these tasks never exit, this can cause Tokio runtime shutdown to hang indefinitely.

This is currently manifested here, which causes the 0FC Integration Tests to frequently time out:

Lines 339 to 346 in abbed3e

    
           self.runtime.block_on(async move { 
        
           	tokio::try_join!( 
        
           		chain_source.update_fee_rate_estimates(), 
        
           		chain_source.validate_zero_fee_commitments_support_if_required( 
        
           			zero_fee_commitments_support_required 
        
           		) 
        
           	) 
        
           })?;

When concurrent requests share an Electrum client connection, a clean EOF can cause the active reader to return an error without waking other requests waiting on the connection. Those requests remain blocked in spawn_blocking, causing Tokio runtime shutdown to wait indefinitely for them to finish.

Hmm, eventually we want to drop the blocking electrum client, but for now the behavior you observed needs to fixed in rust-electrum-client: bitcoindevkit/rust-electrum-client#225

Relatedly opened #1054

Use upstream Electrum EOF fix

And #1055 adds a regression test checking that the electrum-client fix actually fixes our issue.

Navigation Menu

Repository navigation

Tokio runtime shutdown does not abort tasks created via `spawn_blocking` #1007

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	self.runtime.block_on(async move {
	tokio::try_join!(
	chain_source.update_fee_rate_estimates(),
	chain_source.validate_zero_fee_commitments_support_if_required(
	zero_fee_commitments_support_required
	)
	)
	})?;

Tokio runtime shutdown does not abort tasks created via spawn_blocking #1007

Description

Activity

tnull commented on Aug 18, 2026

tnull commented on Aug 18, 2026

tnull commented on Aug 18, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Tokio runtime shutdown does not abort tasks created via `spawn_blocking` #1007