Repository navigation
LSPS1 service integration tracking issue #917
Description
Activity
I would love to take a hand on the full LSP1 services methods for get infos of LSP offers, create the order for inbound liquidity, order payment handling and channel openning. I will propose a PR soon.
I would love to take a hand on the full LSP1 services methods for get infos of LSP offers, create the order for inbound liquidity, order payment handling and channel openning. I will propose a PR soon.
Hi @heyolaniran, thank you for indicating interest, but this isn't available as I'm working on it. This is just a tracking issue for others to follow the progress of the integration.
Reacted by Elias RohrerReacted by Olaniran ⚡can't wait to see your PR then :)
Hey @Anyitechs, just a heads-up that #792 was just merged. it's a refactor of the liquidity module to support multiple LSP nodes and restructures the liquidity source config significantly. You'll likely want to rebase your branch on top of it before continuing, as there will probably be conflicts in that area.
Reacted by Ifeanyichukwu AmajuoyiHey @Anyitechs, just a heads-up that #792 was just merged. it's a refactor of the liquidity module to support multiple LSP nodes and restructures the liquidity source config significantly. You'll likely want to rebase your branch on top of it before continuing, as there will probably be conflicts in that area.
Right, thank you!
Hi @Anyitechs, I've been working on ldk-server and noticed the "Add the service/client support in LDK-Server" item here.
The client side is already usable on the ldk-server side, since ldk-node has
liquidity().lsps1().request_channel()/check_order_status()and ldk-server already registers LSPs throughadd_liquidity_source()(ldk-server#274). What's missing is exposing those calls over the gRPC API and CLI.Would it be ok if I pick up just the LSPS1 client part in ldk-server? I don't want to step on your work, so I'd leave the service side (#1053 and its config in ldk-server) to you. If you were already planning to do the client part too, no worries, just let me know.
For testing I was thinking of starting with unit tests plus manual testing against an existing LSPS1 LSP, and adding an e2e test with ldk-server acting as both LSP and client once #1053 lands.
Hi @Anyitechs, I've been working on ldk-server and noticed the "Add the service/client support in LDK-Server" item here.
The client side is already usable on the ldk-server side, since ldk-node has
liquidity().lsps1().request_channel()/check_order_status()and ldk-server already registers LSPs throughadd_liquidity_source()(ldk-server#274). What's missing is exposing those calls over the gRPC API and CLI.Would it be ok if I pick up just the LSPS1 client part in ldk-server? I don't want to step on your work, so I'd leave the service side (#1053 and its config in ldk-server) to you. If you were already planning to do the client part too, no worries, just let me know.
For testing I was thinking of starting with unit tests plus manual testing against an existing LSPS1 LSP, and adding an e2e test with ldk-server acting as both LSP and client once #1053 lands.
Hi @f3r10, sorry I plan to downstream the full service and client support in LDK-Server.
Reacted by Fernando Ledesma
Context
We currently have LSPS1 client support but no server side support to allow us send and receive bLIP-51 / LSPS1 messages here and in LDK-Server. This will track the progress of the integration.
Todo