Replace funding_redeem_script with output script - #1093
Closed
benthecarman wants to merge 1 commit into
Closed
benthecarman wants to merge 1 commit into
benthecarman wants to merge 1 commit into
Conversation
Expose the funding output's scriptPubKey on ChannelDetails as funding_output_script instead of the witness script. An output script stays meaningful for future taproot channels, where there is no witness script to expose, while a redeem script does not. The field was added after the last release, so no compatibility note is needed. This commit was written with the help of an AI tool. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
👋 I see @tnull was un-assigned. |
tankyleo
approved these changes
Sep 10, 2026
tankyleo
left a comment
tankyleo
left a comment
Contributor
There was a problem hiding this comment.
LGTM tnull let us know what you think. I plan to update the API in rust-lightning for 0.4.
Collaborator
Hmm, is there a rush? I.e., shouldn't LDK Node just follow the API change once it happened in LDK? |
tnull
removed their request for review
September 22, 2026 11:27
Contributor
Author
|
@tankyleo was asking for this mainly, discussed offline and fine to skip. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the funding output's
scriptPubKeyonChannelDetailsasfunding_output_scriptinstead of the witness script. An output script stays meaningful for future taproot channels, where there is no witness script to expose, while a redeem script does not.The field was added after the last release, so no compatibility note is needed.