Skip to content

Handle Channel force-close with pending blocked monitors blocking another channel #2168

Description

@TheBlueMatt

Now (post-#2167 and its followup) that a monitor can block another channel from making progress we need to make sure that a channel force-closing while blocking another monitor (implying it could leave the other monitor blocked if we restart without completing the required monitors which are gone since the channel was deleted) doen't hang us.

Activity

  1. added this to the 0.1 milestone on Apr 7, 2023
  2. modified the milestones: 0.1, 0.0.116 on May 24, 2023
  3. TheBlueMatt commented on May 26, 2023

    @TheBlueMatt
    CollaboratorAuthor
  4. self-assigned this
    on Jun 8, 2023
  5. TheBlueMatt commented on Jul 5, 2023

    @TheBlueMatt
    CollaboratorAuthor

    Re: #2167 (comment) we should be good as of #2167, I pushed the requested comment in #2391.

    Gonna go ahead and close this as completed in #2167 - while its possible there's some edge cases missed, the tests in #2169 show at least the basic cases here were fixed though I'm sill worried a bit about the completion-notification pipeline which I want to rewrite in 117 as #2389.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions