TPT-4706: Fix monitor property mutability - #744
Open
zliang-akamai wants to merge 1 commit into
Open
zliang-akamai wants to merge 1 commit into
zliang-akamai wants to merge 1 commit into
Conversation
zliang-akamai
requested review from
mawilk90 and
yec-akamai
and
a lite review from Copilot
and removed request for
a team
September 24, 2026 21:19
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Add regression coverage confirming the fields cannot be assigned and are excluded from save() payloads.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
Fixes monitor property declarations so four API fields remain read-only and are excluded from update payloads.
Changes:
- Replaces positional enum arguments with
Property(). - Corrects mutability for dashboard, service, and alert fields.
| File | Summary |
|---|---|
linode_api4/objects/monitor.py |
Corrects mutability declarations for four monitor properties. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

📝 Description
Four monitor model properties pass enum classes to
Propertyas positional arguments. That argument controls mutability rather than value conversion, so these read-only API fields were inadvertently writable. Use the defaultProperty()declaration to keep their API values unchanged and prevent them from being included in update payloads.✔️ How to Test