Skip to content

libsecret sometimes doesn't find stored secrets #707

Closed

Description

@michaelkuhn

libsecret sometimes doesn't find stored secrets, for example, when using git-credential-libsecret:

libsecret-CRITICAL **: secret_value_get_text: assertion 'value' failed
libsecret-CRITICAL **: secret_value_unref: assertion 'value != NULL' failed

It also sometimes happens with Evolution, which prompts for all passwords when starting. Restarting Evolution is enough to make the problem go away.

Since I'm not fluent in Rust, I had Claude debug the issue and apparently, the problem is in oo7's OpenSSL backend, which Fedora uses:

client/src/crypto/openssl.rs::generate_aes_key() uses rust-openssl's Dh::compute_key(). It allocates a DH_size() buffer (128 bytes), calls DH_compute_key() and ignores the returned length. DH_compute_key() strips leading zero bytes: it moves the secret to the front of the buffer and zero-fills the tail. If the shared secret starts with a zero byte (about 1 in 256), oo7 gets secret||00, sees a 128-byte value and adds no padding. libsecret (>= 0.21.8, and gcrypt builds) uses the correct 00||secret. HKDF then produces different AES keys, and that session can't decrypt anything.

server/src/gnome/crypto/openssl.rs::generate_aes_key_for_secret_exchange() has the same bug with the 1536-bit group. It's used for the key exchange with the GNOME prompter, so occasionally an unlock prompt probably fails.

I reproduced it with this:

N=2000
work=$(mktemp -d)

printf 'hunter2' | secret-tool store --label='oo7 repro' test oo7-dh-repro || exit 1

echo "Running $N lookups and $N stores"
lookup_fail=0 store_fail=0

for i in $(seq "$N"); do
	value=$(secret-tool lookup test oo7-dh-repro 2>"$work/err")

	if [ "$value" != hunter2 ]; then
		lookup_fail=$((lookup_fail + 1))
		echo "lookup $i failed: got '$value' $(head -c 200 "$work/err")"
	fi

	if ! printf 'hunter2' | secret-tool store --label='oo7 repro' test oo7-dh-repro 2>"$work/err"; then
		store_fail=$((store_fail + 1))
		echo "store $i failed: $(head -c 200 "$work/err")"
	fi
done

With oo7 main (746c38c) and libsecret-0.21.8.2-2.fc45.x86_64:

Running 2000 lookups and 2000 stores
store 46 failed: secret-tool: org.freedesktop.DBus.Error.Failed: Failed to decrypt secret Openssl error: error:1C800064:Provider routines:ossl_cipher_unpadblock:bad decrypt:providers/implementations/ciphers/ciphercomm
lookup 106 failed: got '' 
lookup 121 failed: got '' 
lookup 209 failed: got '' 
lookup 243 failed: got '' 
lookup 432 failed: got '' 
lookup 832 failed: got '' 
lookup 914 failed: got '' 
store 1004 failed: secret-tool: org.freedesktop.DBus.Error.Failed: Failed to decrypt secret Openssl error: error:1C800064:Provider routines:ossl_cipher_unpadblock:bad decrypt:providers/implementations/ciphers/ciphercomm
store 1048 failed: secret-tool: org.freedesktop.DBus.Error.Failed: Failed to decrypt secret Openssl error: error:1C800064:Provider routines:ossl_cipher_unpadblock:bad decrypt:providers/implementations/ciphers/ciphercomm
lookup 1130 failed: got '' 
store 1188 failed: secret-tool: org.freedesktop.DBus.Error.Failed: Failed to decrypt secret Openssl error: error:1C800064:Provider routines:ossl_cipher_unpadblock:bad decrypt:providers/implementations/ciphers/ciphercomm
store 1194 failed: secret-tool: org.freedesktop.DBus.Error.Failed: Failed to decrypt secret Openssl error: error:1C800064:Provider routines:ossl_cipher_unpadblock:bad decrypt:providers/implementations/ciphers/ciphercomm
lookup 1332 failed: got '' 
lookup 1512 failed: got '' 
store 1622 failed: secret-tool: org.freedesktop.DBus.Error.Failed: Failed to decrypt secret Openssl error: error:1C800064:Provider routines:ossl_cipher_unpadblock:bad decrypt:providers/implementations/ciphers/ciphercomm
store 1669 failed: secret-tool: org.freedesktop.DBus.Error.Failed: Failed to decrypt secret Openssl error: error:1C800064:Provider routines:ossl_cipher_unpadblock:bad decrypt:providers/implementations/ciphers/ciphercomm
store 1705 failed: secret-tool: org.freedesktop.DBus.Error.Failed: Failed to decrypt secret Openssl error: error:1C800064:Provider routines:ossl_cipher_unpadblock:bad decrypt:providers/implementations/ciphers/ciphercomm
lookup 1939 failed: got '' 
lookups failed: 11/2000, stores failed: 8/2000

With patched oo7 and libsecret-0.21.8.2-2.fc45.x86_64:

Running 2000 lookups and 2000 stores
lookups failed: 0/2000, stores failed: 0/2000

Activity

  1. bilelmoussaoui commented on Nov 20, 2026

    @bilelmoussaoui
    Collaborator

    Please send that patch as a PR, will review and include it in the next release, thanks

  2. michaelkuhn commented on Nov 20, 2026

    @michaelkuhn
    ContributorAuthor

    Please send that patch as a PR, will review and include it in the next release, thanks

    Done: #708

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions