Skip to content

Various legacy keyring migration quality of life improvements - #692

Merged
bilelmoussaoui merged 4 commits into
mainfrom
bilelmoussaoui/legacy-migration
Nov 19, 2026
Merged

bilelmoussaoui merged 4 commits into
mainfrom
bilelmoussaoui/legacy-migration

Conversation

@bilelmoussaoui

Copy link
Copy Markdown
Collaborator

See commits

Should cover everything mentioned in #688

Migrated items were dispatched without change signals, so clients kept
showing the empty placeholder collection until restarted.

#688
The empty placeholder accepts any secret, so any password silently
unlocked it and hid the pending migration. Validate against the legacy
keyring instead.

#688
@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

📊 Code Coverage Report

Metric Value
Current PR Coverage 84.58%
Main Branch Coverage 84.47%
Coverage Change 📈 +0.11%

Coverage report generated by cargo-tarpaulin

@bilelmoussaoui
bilelmoussaoui force-pushed the bilelmoussaoui/legacy-migration branch from 9c8bd93 to 7f62d92 Compare November 19, 2026 09:04
Otherwise the empty placeholder gets unlocked and the pending migration
can no longer be prompted.

#688
@bilelmoussaoui
bilelmoussaoui force-pushed the bilelmoussaoui/legacy-migration branch from 7f62d92 to 4757025 Compare November 19, 2026 09:05
Replace the validate_legacy_secret free function with a validate_secret
method on the legacy keyring type, alongside decrypt_items and
is_encrypted, so oo7-cli can interact with legacy keyrings too.
@bilelmoussaoui
bilelmoussaoui force-pushed the bilelmoussaoui/legacy-migration branch from 4757025 to fb00531 Compare November 19, 2026 09:16
@bilelmoussaoui
bilelmoussaoui merged commit 2f24f93 into main Nov 19, 2026
14 checks passed
@bilelmoussaoui
bilelmoussaoui deleted the bilelmoussaoui/legacy-migration branch November 19, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant