Repository navigation
server: Expose not yet migrated items as searchable - #694
Merged
Merged
Conversation
The item branch of perform_unlock skipped the migration of a pending legacy keyring and unlocked the empty placeholder instead.
Legacy keyring files keep the items' attributes outside the encrypted block, with values stored as MD5 digests: expose the items carrying those attributes, locked for encrypted keyrings and unlocked with their data for plain keyrings.
SearchItems found nothing in an empty placeholder, so clients created new secrets instead of unlocking the keyring holding the legacy ones. Search the placeholder items by hashing the searched values, and hand their paths to the migrated items on unlock. #690
📊 Code Coverage Report
Coverage report generated by cargo-tarpaulin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This only works for V0 keyrings as they allow searching the items without decrypting them.
Fixes #690
This is a partial fix as #614 is still an issue.