Skip to content

server: Expose not yet migrated items as searchable - #694

Merged
bilelmoussaoui merged 3 commits into
mainfrom
bilelmoussaoui/migration-search
Nov 19, 2026
Merged

bilelmoussaoui merged 3 commits into
mainfrom
bilelmoussaoui/migration-search

Conversation

@bilelmoussaoui

Copy link
Copy Markdown
Collaborator

This only works for V0 keyrings as they allow searching the items without decrypting them.

Fixes #690

This is a partial fix as #614 is still an issue.

The item branch of perform_unlock skipped the migration of a pending
legacy keyring and unlocked the empty placeholder instead.
Legacy keyring files keep the items' attributes outside the encrypted
block, with values stored as MD5 digests: expose the items carrying
those attributes, locked for encrypted keyrings and unlocked with
their data for plain keyrings.
SearchItems found nothing in an empty placeholder, so clients created
new secrets instead of unlocking the keyring holding the legacy ones.
Search the placeholder items by hashing the searched values, and hand
their paths to the migrated items on unlock.

#690
@github-actions

Copy link
Copy Markdown

📊 Code Coverage Report

Metric Value
Current PR Coverage 84.63%
Main Branch Coverage 84.61%
Coverage Change 📈 +0.02%

Coverage report generated by cargo-tarpaulin

@bilelmoussaoui
bilelmoussaoui merged commit 9136079 into main Nov 19, 2026
15 checks passed
@bilelmoussaoui
bilelmoussaoui deleted the bilelmoussaoui/migration-search branch November 19, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Items of a keyring awaiting migration are invisible to SearchItems, so apps create new secrets instead of prompting

1 participant