Skip to content

Handle remaining placeholder collection unlocking - #697

Merged
bilelmoussaoui merged 6 commits into
mainfrom
bilelmoussaoui/change-with-prompt-migration
Nov 19, 2026
Merged

bilelmoussaoui merged 6 commits into
mainfrom
bilelmoussaoui/change-with-prompt-migration

Conversation

@bilelmoussaoui

Copy link
Copy Markdown
Collaborator

See #696

Decrypting an item whose blob is shorter than the mac and the iv
panicked.
The old password step of the prompt unlocked the empty placeholder
instead of migrating the keyring with it.

#696
The unlock role was the only one left leaving clients waiting for a
completion that never comes.
Item.Delete, Collection.Delete and Collection.CreateItem unlocked the
empty placeholder instead of completing the migration.

#696
The PAM unlock and password change unlocked the empty placeholder
instead of completing the migration.

#696
@github-actions

Copy link
Copy Markdown

📊 Code Coverage Report

Metric Value
Current PR Coverage 84.66%
Main Branch Coverage 84.63%
Coverage Change 📈 +0.03%

Coverage report generated by cargo-tarpaulin

@drshields

Copy link
Copy Markdown

Reporter-side check: the new test_change_with_prompt_pending_migration matches the failure I hit exactly, and the gnome/prompter.rs change is the missing piece (the old-secret unlock now goes through unlock_collection() before the new secret is applied). I also walked the remaining set_locked(false) call sites; they are either the no-pending-migration fallback inside unlock_collection() or the generic unlock path, so I don't see an uncovered prompt path. CI shows the new test passing under both native and OpenSSL. Thanks for the quick turnaround.

@bilelmoussaoui
bilelmoussaoui merged commit 831251e into main Nov 19, 2026
15 checks passed
@bilelmoussaoui
bilelmoussaoui deleted the bilelmoussaoui/change-with-prompt-migration branch November 20, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ChangeWithPrompt on a pending v0 migration does not migrate; new password fails after reboot

2 participants