Repository navigation
server: Keep the locked keyring on a failed unlock - #702
Merged
Merged
Conversation
A failed unlock reloaded the keyring from disk, which bricks the collection when the file can no longer be parsed and silently discards the in-memory items when it was deleted. Add a borrowing LockedKeyring::try_unlock that leaves the keyring untouched on failure and use it from the server.
📊 Code Coverage Report
Coverage report generated by cargo-tarpaulin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed unlock reloaded the keyring from disk, which bricks the collection when the file can no longer be parsed and silently discards the in-memory items when it was deleted.