Skip to content

server: Keep the locked keyring on a failed unlock - #702

Merged
bilelmoussaoui merged 1 commit into
mainfrom
bilelmoussaoui/keyring-try-unlock
Nov 19, 2026
Merged

bilelmoussaoui merged 1 commit into
mainfrom
bilelmoussaoui/keyring-try-unlock

Conversation

@bilelmoussaoui

Copy link
Copy Markdown
Collaborator

A failed unlock reloaded the keyring from disk, which bricks the collection when the file can no longer be parsed and silently discards the in-memory items when it was deleted.

A failed unlock reloaded the keyring from disk, which bricks the
collection when the file can no longer be parsed and silently discards
the in-memory items when it was deleted. Add a borrowing
LockedKeyring::try_unlock that leaves the keyring untouched on failure
and use it from the server.
@github-actions

Copy link
Copy Markdown

📊 Code Coverage Report

Metric Value
Current PR Coverage 84.72%
Main Branch Coverage 84.72%
Coverage Change ➡️ 0.00%

Coverage report generated by cargo-tarpaulin

@bilelmoussaoui
bilelmoussaoui merged commit 06ebcc1 into main Nov 19, 2026
15 checks passed
@bilelmoussaoui
bilelmoussaoui deleted the bilelmoussaoui/keyring-try-unlock branch November 19, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant