Repository navigation
Refuse deleting not yet migrated collections/items - #705
Merged
Merged
Conversation
📊 Code Coverage Report
🎉 Great: Coverage increased by more than 1%! Coverage report generated by cargo-tarpaulin |
The login helper is a binary spawned from the PAM module, tarpaulin can't execute it. The combined LCOV file is kept around, it has the per-line records the JSON report lacks. The HTML report stays at coverage/html, where grcov nests it and the CI parses its coverage.json summary.
The terminal prompter used by CLI sessions and the dismiss cleanup of the plasma prompter callback had no coverage.
A wrong password left the prompt completed without a signal, hanging the client until its timeout. Prompt again up to the maximum unlock attempts, then emit the dismissed completion.
A secret arriving before the service is initialized is buffered and replayed once the keyrings are discovered, and garbage on the PAM socket fails the connection without taking the listener down.
Deleting it prompted for the secret, completed the migration and threw the result away, destroying the legacy keyring's data. Unlock the collection first to migrate it, then delete it if that is really wanted.
Like the collection deletion, it would migrate the legacy keyring and throw the item away. Storing items keeps migrating transparently, only destructive operations now require unlocking first.
bilelmoussaoui
force-pushed
the
bilelmoussaoui/issue-703
branch
from
November 20, 2026 14:38
58b14e3 to
300dfec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even if the user would be prompted to unlock the collection first, unlocking it would lead to the collection being deleted directly... Instead, let us bail-out and let the user decide to delete post-unlocking as they might think the collection is empty when it is not.
Also add test cases for the CLI prompter and fix some issues there that can cause a hang when the typed password is wrong.