Skip to content

Refuse deleting not yet migrated collections/items - #705

Merged
bilelmoussaoui merged 6 commits into
mainfrom
bilelmoussaoui/issue-703
Nov 20, 2026
Merged

bilelmoussaoui merged 6 commits into
mainfrom
bilelmoussaoui/issue-703

Conversation

@bilelmoussaoui

Copy link
Copy Markdown
Collaborator

Even if the user would be prompted to unlock the collection first, unlocking it would lead to the collection being deleted directly... Instead, let us bail-out and let the user decide to delete post-unlocking as they might think the collection is empty when it is not.

Also add test cases for the CLI prompter and fix some issues there that can cause a hang when the typed password is wrong.

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

📊 Code Coverage Report

Metric Value
Current PR Coverage 87.76%
Main Branch Coverage 84.77%
Coverage Change 📈 +2.99%

🎉 Great: Coverage increased by more than 1%!

Coverage report generated by cargo-tarpaulin

The login helper is a binary spawned from the PAM module, tarpaulin
can't execute it. The combined LCOV file is kept around, it has the
per-line records the JSON report lacks.

The HTML report stays at coverage/html, where grcov nests it and the
CI parses its coverage.json summary.
The terminal prompter used by CLI sessions and the dismiss cleanup of
the plasma prompter callback had no coverage.
A wrong password left the prompt completed without a signal, hanging
the client until its timeout. Prompt again up to the maximum unlock
attempts, then emit the dismissed completion.
A secret arriving before the service is initialized is buffered and
replayed once the keyrings are discovered, and garbage on the PAM
socket fails the connection without taking the listener down.
Deleting it prompted for the secret, completed the migration and threw
the result away, destroying the legacy keyring's data. Unlock the
collection first to migrate it, then delete it if that is really
wanted.
Like the collection deletion, it would migrate the legacy keyring and
throw the item away. Storing items keeps migrating transparently, only
destructive operations now require unlocking first.
@bilelmoussaoui
bilelmoussaoui force-pushed the bilelmoussaoui/issue-703 branch from 58b14e3 to 300dfec Compare November 20, 2026 14:38
@bilelmoussaoui
bilelmoussaoui merged commit bb65df7 into main Nov 20, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant