fixed scrollbar overwriting window borders on wayland

[WerIstLuka]

the scrollbar overwrites the window border on wayland
creating a 1px transparent border around the scrollbar fixes it

mint-l has the same issue, i also made a pr there with the same change

i opened a wayland issue on this a while ago, fixed it for my theme and closed the issue but forgot to fix it for mint-y and mint-l linuxmint/wayland#156

[echuber2]

I wonder if this fix is needed for other types of windows that might not have typical borders. Is there a way to generalize it without constraining it to the terminal style? What about adding padding (or maybe margin) around the scrollbar instead of an invisible border?

[WerIstLuka]

i've been daily driving the wayland session for a while now and i havn't seen any other window with this issue

i fixed this issue a few weeks ago but forgot to make a pr so i have no idea why i chose to make an invisible border. margin or padding might also work but i just copied what i did with my theme to fix it

[mtwebster]

This belongs in _applications.scss: terminal-screen-container is already handled there.

Also, probably why you're only experiencing this in Wayland is because even though gnome-terminal 'appears' to be a server-decorated window, the app itself is actually drawing the border as well as its own content, so overlap can occur.

Contrast this with X11 sessions, muffin draws the borders here, so there can't ever be overlap between borders and content.

You could probably be more specific here and use:

.csd terminal-screen-container scrollbar {
    border-style: solid;
    border-width: 1px;
}

I didn't check your Mint-L pull request yet, but it should have the same structure I think.

[WerIstLuka]

This belongs in _applications.scss: terminal-screen-container is already handled there.

I'll move it there and make it more specific

Also, probably why you're only experiencing this in Wayland is because even though gnome-terminal 'appears' to be a server-decorated window, the app itself is actually drawing the border as well as its own content, so overlap can occur.

Contrast this with X11 sessions, muffin draws the borders here, so there can't ever be overlap between borders and content.

I was confused why this was only on wayland but this makes a lot of sense

I didn't check your Mint-L pull request yet, but it should have the same structure I think.

yeah its exactly the same as this