Skip to content

Improved generation of themes - #557

Open
WerIstLuka wants to merge 14 commits into
linuxmint:masterfrom
WerIstLuka:improved-build
Open

WerIstLuka wants to merge 14 commits into
linuxmint:masterfrom
WerIstLuka:improved-build

Conversation

@WerIstLuka

Copy link
Copy Markdown
Contributor

what I did:

  • remove useless code
  • remove duplicate code by using functions
  • replace the "%s" % var notation with f"{var}" (f-strings)
  • speed up generate-themes.py and update-variations.py by using multiple threads

I verified multiple times that the resulting files are equal

The changes in src/Mint-Y/variations also happened on an unmodified fork so someone probably just forgot to run it

What about Mint-L? I heard that it won't stick around for long so I wanna know if it wouldn't be an awful decision doing the same to Mint-L

The speedups are quite big for me

  • update-variations.py went from roughly 12:30 to 02:10
  • generate-themes.py went from roughly 00:14 to 00:02

Tested on: Ryzen 5 9600x, 48gb ddr5 5600mt/s dual channel, pcie gen4 nvme, Linux Mint 22.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant