Skip to content

Drop redundant queue conditions and require no failing check - #21

Merged
mergify[bot] merged 1 commit into
mainfrom
mergify-queue-tune
Oct 22, 2026
Merged

mergify[bot] merged 1 commit into
mainfrom
mergify-queue-tune

Conversation

@littlenano

Copy link
Copy Markdown
Collaborator

Follow-up to #19, which landed the configuration as code but kept three things that are either defaults or not strict enough.

Dropped, because Mergify already does it:

  • queue_conditions: base = main, -draft — -closed, -conflict and -draft are Mergify's own queue requirements, and this repository's pull requests all target main;
  • batch_size: 1 — the default.

Added, because a merge must not land on a broken pull request:

  • "#check-failure = 0" — no check may be failing, not just check.

check-success = check stays: #check-failure = 0 alone is also satisfied when no check has run at all, so the explicit success keeps an empty check list from counting as green.

Consequence of dropping queue_conditions: the queue also accepts pull requests targeting other base branches, since Mergify creates one queue per branch. Add base = main back if that should be restricted.

Mergify validates the file on this pull request; it takes effect once merged into main.

Co-authored-by: Lin Yinfeng <lin.yinfeng@outlook.com>
@mergify

mergify Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Queued — the merge queue status continues in this comment ↓.

@mergify

mergify Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Merge Queue Status

This pull request spent 1 minute 17 seconds in the queue, including 33 seconds running CI.

Required conditions to merge
  • check-success = check

@mergify mergify Bot added the queued label Oct 22, 2026
@mergify mergify Bot mentioned this pull request Oct 22, 2026
3 tasks done
@mergify
mergify Bot merged commit c810c81 into main Oct 22, 2026
7 checks passed
@mergify mergify Bot removed the queued label Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant