Repository navigation
Drop redundant queue conditions and require no failing check - #21
Merged
Merged
Conversation
Co-authored-by: Lin Yinfeng <lin.yinfeng@outlook.com>
|
Queued — the merge queue status continues in this comment ↓. |
Merge Queue Status
This pull request spent 1 minute 17 seconds in the queue, including 33 seconds running CI. Required conditions to merge
|
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #19, which landed the configuration as code but kept three things that are either defaults or not strict enough.
Dropped, because Mergify already does it:
queue_conditions: base = main,-draft—-closed,-conflictand-draftare Mergify's own queue requirements, and this repository's pull requests all targetmain;batch_size: 1— the default.Added, because a merge must not land on a broken pull request:
"#check-failure = 0"— no check may be failing, not justcheck.check-success = checkstays:#check-failure = 0alone is also satisfied when no check has run at all, so the explicit success keeps an empty check list from counting as green.Consequence of dropping
queue_conditions: the queue also accepts pull requests targeting other base branches, since Mergify creates one queue per branch. Addbase = mainback if that should be restricted.Mergify validates the file on this pull request; it takes effect once merged into
main.