Repository navigation
Consolidate repository packfiles on a timer - #24
Merged
Merged
Conversation
Co-authored-by: Lin Yinfeng <lin.yinfeng@outlook.com>
|
Queued — the merge queue status continues in this comment ↓. |
Merge Queue Status
This pull request spent 1 minute 16 seconds in the queue, including 32 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every
git fetchthat receives objects writes a new packfile, and nothing consolidates them in this workload:gc --autotrigger never fires, because objects arrive packed (a mirror here has 0 loose objects);git fetchnever creates.On the nixpkgs mirror this accumulated 34,701 packfiles over five months. Each fetch then had to open every pack, so a fetch that found new objects took 4–5 minutes of one core, and one was always running.
A single
git repack --geometric=2 -d --write-midxfixes it, and is cheap enough to repeat:This adds
services.commit-notifier.maintenance(enabled by default): a oneshot service running that repack over/var/lib/commit-notifier/repositories/*/repo, scheduled byOnCalendar = cfg.maintenance.calendar(defaultdaily) withPersistentand a randomised delay, as thecommit-notifieruser withNice = 10and idle I/O scheduling so it does not compete with the fetches.