Repository navigation
README: make DNS resolution status unambiguous - #15
Merged
Merged
Conversation
The Roadmap listed "DNS + HTTP resolution in SOVPValidator" as Implemented while the same table lists the SOVPValidator class as Planned. The DNS setup note named only resolve_dns_pubkey(), not the key-set function that validate_domain() actually uses. Both now say what is implemented in sovp.resolver; the intro and install section name sovp.resolver too. CHANGELOG notes that the immutable PyPI pages for 1.0.1-1.0.5 still show the old "not yet implemented" sentence. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014bYT9B2DbzQj9zYxs3QrzB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automatic DNS key resolution has been implemented since 1.0.2 (
sovp.resolver) and has been in the installable wheel since 1.0.4. The old "Automatic DNS resolution is not yet implemented" sentence was already removed onmainin 1d950e8, but the README still had one contradiction and some imprecise wording:SOVPValidator: Implemented" sat in the same table as "SOVPValidatorclass API: Planned". The row now names what is actually implemented (sovp.resolver), and the class-API row is described as an OO wrapper over the existing functions.resolve_dns_pubkeys()(up to fourv=SOVP1records, for key rotation), which is whatvalidate_domain()uses, and the strict record parsing. It also separates this from the network-freesovp.coreverify functions.sovp.resolveralongsidesovp.core.[Unreleased]: records the change and notes that the immutable PyPI pages for 1.0.1–1.0.5 still show the old "not yet implemented" sentence.No code changes.
Verification
pytest: 80 passed.validate_domain("litzki-systems.com")pipeline returnspsi_core=1, reason=ok. DNS answers came via DNS-over-HTTPS because the sandbox resolver returns no TXT records._sovp.litzki-systems.compublishesv=SOVP1; k=AjNz…aw8=.Generated by Claude Code